Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› οΈ [TASK] : Add stub endpoints to support norns #1046

Open
6 tasks done
apskhem opened this issue Oct 24, 2024 · 0 comments Β· May be fixed by #1055
Open
6 tasks done

πŸ› οΈ [TASK] : Add stub endpoints to support norns #1046

apskhem opened this issue Oct 24, 2024 · 0 comments Β· May be fixed by #1055
Assignees
Labels
enhancement New feature or request

Comments

@apskhem
Copy link
Collaborator

apskhem commented Oct 24, 2024

Summary

Stub and Add Endpoints to Catalyst-Voices for Norns App Compatibility (No Implementation Needed)

Description

  • The endpoints should be fully stubbed with proper return types that match the original system.
  • They do not need actual implementations at this time, just enough functionality for the Norns app to work with them.
  • Analyze what these endpoints do in the original system and how the norns app interacts with the responses.
  • Ensure they work as needed for norns, but do not expose them in the public API. These endpoints will be deprecated and hidden before we go live.

Reference this repository for context: Norns Repository Search.

As listed in this epic.
This ticket aims to implement only 6 of them.

  • GET /api/v0/settings - App.getAppSettings()
  • GET /api/v0/fund/ - Fund.show()
  • GET /api/v0/proposals - Proposal.index()
  • POST /api/v0/proposals - Proposal.get_proposal_by_idx(votingHistoryList)
  • GET /api//v0/proposals/${id} - Proposal.show(id)
  • GET /api/v0/reviews/${proposalId} - Proposal.review(proposalId)
@apskhem apskhem added this to Catalyst Oct 24, 2024
@apskhem apskhem moved this from New to πŸ”– Ready in Catalyst Oct 24, 2024
@apskhem apskhem self-assigned this Oct 24, 2024
@apskhem apskhem moved this from πŸ”– Ready to πŸ— In progress in Catalyst Oct 24, 2024
@apskhem apskhem added the enhancement New feature or request label Oct 24, 2024
@apskhem apskhem linked a pull request Oct 28, 2024 that will close this issue
8 tasks
@apskhem apskhem added this to the M4: Voting & Delegation milestone Oct 29, 2024
@apskhem apskhem moved this from πŸ‘€ In review to πŸ›‘ Blocked in Catalyst Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: πŸ›‘ Blocked
1 participant