Skip to content

Commit 0f35c9b

Browse files
authored
chore: voices packages clean up (#147)
* chore: update readme, remove unused files * Create melos_example.iml * Delete analysis_options.yaml * docs (catalyst_analysis): update README * Update analysis_options.1.0.0.yaml * chore: update dart lints * Update README.md * fix typo in workflow file names
1 parent a182c21 commit 0f35c9b

18 files changed

+44
-102
lines changed

catalyst_voices/analysis_options.yaml

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
include: package:catalyst_analysis/analysis_options.1.0.0.yaml
22

3-
exclude:
4-
- 'build/**'
5-
- '**/*.g.dart'
3+
analyzer:
4+
exclude: [
5+
build/**,
6+
lib/*.g.dart,
7+
lib/generated/**
8+
]
69

710
linter:
811
rules:

catalyst_voices/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ dependencies:
1414
flutter_bloc: ^8.1.3
1515
flutter_localizations:
1616
sdk: flutter
17-
intl: ^0.18.0
17+
intl: ^0.18.1
1818

1919
dev_dependencies:
2020
bloc_test: ^9.1.4

catalyst_voices_packages/.idea/.name

-1
This file was deleted.

catalyst_voices_packages/.idea/modules.xml

-10
This file was deleted.

catalyst_voices_packages/.idea/runConfigurations/melos_bootstrap.xml

-11
This file was deleted.

catalyst_voices_packages/.idea/runConfigurations/melos_clean.xml

-11
This file was deleted.

catalyst_voices_packages/.idea/runConfigurations/melos_run_analyze.xml

-11
This file was deleted.

catalyst_voices_packages/.idea/runConfigurations/melos_run_lint_all.xml

-11
This file was deleted.

catalyst_voices_packages/.idea/runConfigurations/melos_run_qualitycheck.xml

-11
This file was deleted.

catalyst_voices_packages/README.md

+21-10
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
# Catalyst Flutter
1+
# Catalyst Voices Packages
22

33
A collection of Catalyst packages and plugins for Flutter and Dart.
44

5-
* [Catalyst Flutter](#catalyst-flutter)
5+
* [Catalyst Voices Packages](#catalyst-voices-packages)
66
* [Packages](#packages)
77
* [Requirements](#requirements)
88
* [Bootstrapping](#bootstrapping)
9+
* [Contributing](#contributing)
910
* [Support](#support)
1011
* [License](#license)
1112

@@ -17,9 +18,9 @@ A collection of Catalyst packages and plugins for Flutter and Dart.
1718

1819
## Requirements
1920

20-
* Flutter: 3.13.4+
21-
* Dart: 3.1.2+
22-
* Xcode: 14.2+
21+
* Flutter: 3.13.9+
22+
* Dart: 3.1.5+
23+
* Xcode: 15.0+
2324
* Android Studio: Android Studio Electric Eel | 2022.1.1 +
2425
* [Melos](https://melos.invertase.dev)
2526
* Flutter & Dart plugins:
@@ -30,16 +31,26 @@ A collection of Catalyst packages and plugins for Flutter and Dart.
3031
## Bootstrapping
3132

3233
```sh
33-
git clone TODO(minikin): add repo
34-
cd catalyst_flutter
34+
git clone https://github.com/input-output-hk/catalyst-voices.git
35+
cd catalyst-voices
3536
melos bootstrap
3637
```
3738

39+
## Contributing
40+
41+
We welcome contributions from the community!
42+
Please read our [CONTRIBUTING](https://github.com/input-output-hk/catalyst-voices/blob/main/CONTRIBUTING.md)
43+
for guidelines on how to contribute.
44+
3845
## Support
3946

40-
Post issues and feature requests on the GitHub [issue tracker](TODO(minikin)).
47+
Post issues and feature requests on the GitHub [issue tracker](https://github.com/input-output-hk/catalyst-voices/issues).
4148

4249
## License
4350

44-
The source code of Popover project is available under the TODO(minikin): add license.
45-
See the [LICENSE](TODO(minikin)) file for more info.
51+
Licensed under either of [Apache License, Version 2.0](https://github.com/input-output-hk/catalyst-voices/blob/main/LICENSE-APACHE)
52+
or [MIT license](https://github.com/input-output-hk/catalyst-voices/blob/main/LICENSE-MIT) at your option.
53+
54+
Unless you explicitly state otherwise, any contribution intentionally submitted
55+
for inclusion in this crate by you, as defined in the Apache-2.0 license, shall
56+
be dual licensed as above, without any additional terms or conditions.

catalyst_voices_packages/analysis_options.yaml

Whitespace-only changes.

catalyst_voices_packages/packages/catalyst_analysis/CONTRIBUTING.md

-1
This file was deleted.

catalyst_voices_packages/packages/catalyst_analysis/LICENSE

-3
This file was deleted.

catalyst_voices_packages/packages/catalyst_analysis/README.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# 🧐 Catalyst Analysis
22

33
This package provides lint rules for Dart and Flutter which are used at [Catalyst @ IOG](https://github.com/input-output-hk).
4-
For more information, see the [complete list of options](TODO(minikin)).
4+
For more information,
5+
see the [complete list of options](/catalyst_voices_packages/packages/catalyst_analysis/lib/analysis_options.1.0.0.yaml).
56

67
> This package was heavily inspired by [lint](https://pub.dev/packages/lints)
78
> and real-life experience building products with Dart and Flutter.
@@ -79,10 +80,10 @@ As the Dart language and its ecosystem evolve, it is important to keep lint sets
7980
Regularly updating them to reflect the best practices for writing Dart code.
8081
To accomplish this, we have an informal process in place:
8182

82-
1. Individuals can submit an [issue](TODO(minikin)) to discuss potential changes to the lint sets
83-
(such as adding or removing a lint).
84-
Feedback is welcome from all Dart/Flutter users.
83+
* Individuals can submit an [issue](https://github.com/input-output-hk/catalyst-voices/issues)
84+
to discuss potential changes to the lint sets (such as adding or removing a lint).
85+
Feedback is welcome from all Dart/Flutter users.
8586

86-
2. Catalyst Engineering team meets periodically to review suggestions and make decisions on what to change.
87+
* Catalyst Engineering team meets periodically to review suggestions and make decisions on what to change.
8788

88-
3. Once the updates are made, a new version of the package is published.
89+
* Once the updates are made, a new version of the package is published.

catalyst_voices_packages/packages/catalyst_analysis/lib/analysis_options.1.0.0.yaml

+8-11
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,17 @@ analyzer:
44
strict-inference: true
55
strict-raw-types: true
66

7-
errors:
8-
missing_required_param: error
9-
missing_return: error
10-
117
exclude:
128
- test/.test_coverage.dart
139
- lib/generated_plugin_registrant.dart
1410

15-
# The full list of lints: https://dart-lang.github.io/linter/lints/index.html
11+
# The full list of lints: https://dart.dev/tools/linter-rules
1612
linter:
1713
rules:
1814
- always_declare_return_types
19-
- always_require_non_null_named_parameters
2015
- always_use_package_imports
2116
- annotate_overrides
17+
# - annotate_redeclares # Enabled as Dart 3.2.0 will be released
2218
- avoid_bool_literals_in_conditional_expressions
2319
- avoid_catching_errors
2420
- avoid_double_and_int_checks
@@ -40,7 +36,6 @@ linter:
4036
- avoid_relative_lib_imports
4137
- avoid_renaming_method_parameters
4238
- avoid_return_types_on_setters
43-
- avoid_returning_null
4439
- avoid_returning_null_for_future
4540
- avoid_returning_null_for_void
4641
- avoid_returning_this
@@ -60,14 +55,17 @@ linter:
6055
- cancel_subscriptions
6156
- cascade_invocations
6257
- cast_nullable_to_non_nullable
58+
- collection_methods_unrelated_type
6359
- comment_references
6460
- conditional_uri_does_not_exist
6561
- constant_identifier_names
6662
- control_flow_in_finally
6763
- curly_braces_in_flow_control_structures
64+
- dangling_library_doc_comments
6865
- depend_on_referenced_packages
6966
- deprecated_consistency
7067
- directives_ordering
68+
- discarded_futures
7169
- empty_catches
7270
- empty_constructor_bodies
7371
- empty_statements
@@ -77,14 +75,14 @@ linter:
7775
- flutter_style_todos
7876
- hash_and_equals
7977
- implementation_imports
80-
- iterable_contains_unrelated_type
78+
- implicit_reopen
79+
- invalid_case_patterns
8180
- join_return_with_assignment
8281
- leading_newlines_in_multiline_strings
8382
- library_names
8483
- library_prefixes
8584
- library_private_types_in_public_api
8685
- lines_longer_than_80_chars
87-
- list_remove_unrelated_type
8886
- literal_only_boolean_expressions
8987
- missing_whitespace_between_adjacent_strings
9088
- no_adjacent_strings_in_list
@@ -94,6 +92,7 @@ linter:
9492
- no_leading_underscores_for_local_identifiers
9593
- no_logic_in_create_state
9694
- no_runtimeType_toString
95+
- no_self_assignments
9796
- non_constant_identifier_names
9897
- noop_primitive_operations
9998
- null_check_on_nullable_type_parameter
@@ -117,7 +116,6 @@ linter:
117116
- prefer_const_literals_to_create_immutables
118117
- prefer_constructors_over_static_methods
119118
- prefer_contains
120-
- prefer_equal_for_default_values
121119
- prefer_final_fields
122120
- prefer_final_in_for_each
123121
- prefer_final_locals
@@ -170,7 +168,6 @@ linter:
170168
- unnecessary_null_in_if_null_operators
171169
- unnecessary_nullable_for_final_variable_declarations
172170
- unnecessary_overrides
173-
- unnecessary_parenthesis
174171
- unnecessary_raw_strings
175172
- unnecessary_statements
176173
- unnecessary_string_escapes

catalyst_voices_packages/packages/catalyst_analysis/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ version: 1.0.0
33
description: Lint rules for Dart and Flutter used internally at Catalyst.
44

55
environment:
6-
sdk: '>=3.1.2 <4.0.0'
6+
sdk: '>=3.1.5 <4.0.0'

0 commit comments

Comments
 (0)