Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust/rbac-registration): Introduce Cip0134UriList type #106

Closed
wants to merge 3 commits into from
Closed

feat(rust/rbac-registration): Introduce Cip0134UriList type #106

wants to merge 3 commits into from

Conversation

stanislav-tkach
Copy link
Contributor

@stanislav-tkach stanislav-tkach commented Dec 13, 2024 •
edited
Loading

Description

  • The Cip0134UriList type was added.

Related Issue(s)

Closes #104.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stanislav-tkach stanislav-tkach added the do not merge yet PR is not ready to merge yet label Dec 13, 2024
@stanislav-tkach stanislav-tkach self-assigned this Dec 13, 2024
@stanislav-tkach stanislav-tkach force-pushed the cip0134list branch 3 times, most recently from d7f51fc to fa8bf59 Compare December 15, 2024 12:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 229/229}$ | ${\color{red}Fail: 0/229}$ |

@stanislav-tkach stanislav-tkach force-pushed the cip0134list branch 2 times, most recently from 1f97a27 to 503d464 Compare December 16, 2024 12:50
@stanislav-tkach stanislav-tkach added review me PR is ready for review and removed do not merge yet PR is not ready to merge yet labels Dec 16, 2024
@stanislav-tkach stanislav-tkach marked this pull request as ready for review December 16, 2024 15:56
@stanislav-tkach stanislav-tkach force-pushed the cip0134list branch 3 times, most recently from cba812f to a13fa1b Compare December 16, 2024 21:34
Mr-Leshiy
Mr-Leshiy previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach
Copy link
Contributor Author

Rebased on top of the #110 fix.

bkioshn
bkioshn reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Look much cleaner 🥳

@stanislav-tkach stanislav-tkach added do not merge yet PR is not ready to merge yet and removed review me PR is ready for review labels Dec 17, 2024
@stanislav-tkach
Copy link
Contributor Author

Closed in favor of #119.

@stanislav-tkach stanislav-tkach deleted the cip0134list branch December 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkioshn bkioshn bkioshn left review comments

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@stanislav-tkach stanislav-tkach

Labels
do not merge yet PR is not ready to merge yet
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Create a type representing a list of CIP-0134 URIs
4 participants
@stanislav-tkach @Mr-Leshiy @bkioshn @stevenj