From 7cf94dfe761a0ebc6c53833a6aab438c86eee2cd Mon Sep 17 00:00:00 2001
From: cong-or <60357579+cong-or@users.noreply.github.com>
Date: Tue, 30 Jan 2024 14:03:59 +0000
Subject: [PATCH] fix(rm spending counter tests): audit tooling f11 (#665)

NOT PRODUCTION CODE

The following is our[ production
chain-libs](https://github.com/input-output-hk/chain-libs/tree/catalyst-fund9-gold)

We have removed spending counter logic long ago due to inherent flaws in
the context of correctness. Audit tooling on cat core needs to reflect
this to perform a correct offline tally without errors hence removing
the checks.
---
 .../src/accounting/account/spending.rs        | 30 ++++---------------
 1 file changed, 5 insertions(+), 25 deletions(-)

diff --git a/src/chain-libs/chain-impl-mockchain/src/accounting/account/spending.rs b/src/chain-libs/chain-impl-mockchain/src/accounting/account/spending.rs
index ba755635f6..b79d5124b4 100644
--- a/src/chain-libs/chain-impl-mockchain/src/accounting/account/spending.rs
+++ b/src/chain-libs/chain-impl-mockchain/src/accounting/account/spending.rs
@@ -58,34 +58,14 @@ impl SpendingCounterIncreasing {
     /// an error reported.
     ///
     /// If the counter match succesfully, then the counter at this lane is incremented by one.
-    pub fn next_verify(&mut self, counter: SpendingCounter) -> Result<(), Error> {
-        let actual_counter = self.nexts[counter.lane()];
-
-        if actual_counter != counter {
-            Err(Error::SpendingCredentialInvalid {
-                expected: actual_counter,
-                actual: counter,
-            })
-        } else {
-            self.next_unchecked(counter);
-            Ok(())
-        }
+    pub fn next_verify(&mut self, _counter: SpendingCounter) -> Result<(), Error> {
+        // spending counter has been removed
+        Ok(())
     }
 
     /// Increases the spending counter on the given lane.
-    pub(crate) fn next_unchecked(&mut self, unchecked_counter: SpendingCounter) {
-        let lane = unchecked_counter.lane();
-        let counter_to_update = self.nexts[lane];
-        if counter_to_update != unchecked_counter {
-            tracing::warn!(
-                "Invalid spending counter, {}",
-                Error::SpendingCredentialInvalid {
-                    expected: counter_to_update,
-                    actual: unchecked_counter,
-                }
-            );
-        }
-        self.nexts[lane] = counter_to_update.increment();
+    pub(crate) fn next_unchecked(&mut self, _unchecked_counter: SpendingCounter) {
+        // spending counter removed
     }
 }