Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for notes #14

Open
infojunkie opened this issue Feb 17, 2023 · 1 comment
Open

Better naming for notes #14

infojunkie opened this issue Feb 17, 2023 · 1 comment

Comments

@infojunkie
Copy link
Owner

infojunkie commented Feb 17, 2023

Right now, a tone row like the following:

const minor = Scalextric.ToneRow.fromPitchClasses(edo12, [0, 2, 3, 5, 7, 9, 11, 12], 4);

will generate notes named C4, D4, D#4, F4, etc. Here, D# should be Eb because the minor scale is expected to be diatonic and not contain the same note twice.

This rule cannot be expressed in the current TuningNotation which assigns the names D# and Eb to tone 3.

@infojunkie
Copy link
Owner Author

The key is to extend the naming logic to every musical object. For example, the ToneRow (or better yet, a Scale) would know how to name its own tones based on inherent naming logic. Specifically, that no pitch letter should be repeated or some such rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant