Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry feature for http secret-store plugin #15846

Open
YoonSungHyun-Git opened this issue Sep 5, 2024 · 1 comment
Open

Add retry feature for http secret-store plugin #15846

YoonSungHyun-Git opened this issue Sep 5, 2024 · 1 comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/l 1 week or more effort

Comments

@YoonSungHyun-Git
Copy link

YoonSungHyun-Git commented Sep 5, 2024

Use Case

Use the scretstore http plugin to retrieve connection information from postgresql output.
However, in the current situation, if the secretstore http plugin fails to retrieve the API value, the service does not start because @ variable substitution is not performed.

Expected behavior

  • API call setup : Use @ variable
  • API connection failure : Retry

Actual behavior

  • API call setup : Use @ variable
  • API connection failure : service down
    ( The reason is that the @ variable does not have a value and attempts to connect in an unsubstituted state.)

Additional info

[[secretstores.http]]
  id = "meta"
  url = "http://localhost/meta"
  timeout = "5s"
  
[[outputs.postgresql]]
  connection = "host=@{meta:host} port=@{meta:port} user=@{meta:user} password=@{meta:password} dbname=@{meta:database} sslmode=disable"
@YoonSungHyun-Git YoonSungHyun-Git added the feature request Requests for new plugin and for new features to existing plugins label Sep 5, 2024
@srebhan srebhan changed the title Scretstore http plugin retry feature Add retry feature for http secret-store plugin Sep 10, 2024
@srebhan
Copy link
Member

srebhan commented Sep 10, 2024

Next steps: Look into code on how to realize this best. We probably cannot error out on startup then and all downstream users of the secret-store need to cope with the fallout. This might take some time...

@srebhan srebhan added help wanted Request for community participation, code, contribution size/l 1 week or more effort labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/l 1 week or more effort
Projects
None yet
Development

No branches or pull requests

2 participants