-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASL/OAUTHBEARER support #252
Comments
Yes, PRs are welcome 🙂
I think if it's really just one method, type AuthCallback = Box<dyn Fn(Input) -> BoxFuture<'static, Output> + Send + Sync + 'static>; |
Yeah, that looks good. I'll probably look into it then, thanks! |
Would you be willing to accept a contribution implementing SASL/OAUTHBEARER support? This should be relatively simple, especially now that the library depends on
rsasl
.The only wrinkle is that this would probably need to contain some form of callback, since on reconnect the client would likely need to request a new token. This callback should probably be async, since it will usually involve some form of async operation. This means
async_trait
or, if you would prefer to avoid that dependency, requiring users to box their futures themselves with a trait returningPin<Box<dyn Future<Output = ...> + 'static>>
.Thoughts? I would be willing contribute this, but I'd rather nail down the approach you prefer first.
The text was updated successfully, but these errors were encountered: