Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule and WAL plugin channels should be separated #25879

Closed
pauldix opened this issue Jan 21, 2025 · 0 comments · Fixed by #25908
Closed

Schedule and WAL plugin channels should be separated #25879

pauldix opened this issue Jan 21, 2025 · 0 comments · Fixed by #25908
Assignees
@pauldix
Labels
v3

Comments

@pauldix
Copy link
Member

pauldix commented Jan 21, 2025

The plugin channels that receive notifications should be separated. See https://github.com/influxdata/influxdb/blob/main/influxdb3_processing_engine/src/lib.rs#L43-L46

WAL and Schedule plugins should have their own separate collections so that WALContents aren't sent to schedules
@pauldix pauldix added the v3 label Jan 21, 2025
@pauldix pauldix self-assigned this Jan 23, 2025
pauldix added a commit that referenced this issue Jan 23, 2025
@pauldix
feat: each plugin type uses its own channel
7cf1d18 
This cleans up how plugins receive their triggering events. It'll also clean up the logs a bit without warnings that plugin events of the wrong type are going to different plugins.

Closes #25879
@pauldix pauldix mentioned this issue Jan 23, 2025
Merged
pauldix added a commit that referenced this issue Jan 23, 2025
@pauldix
feat: each plugin type uses its own channel
7c38b8b 
This cleans up how plugins receive their triggering events. It'll also clean up the logs a bit without warnings that plugin events of the wrong type are going to different plugins.

Closes #25879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauldix pauldix

Labels
v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: each plugin type uses its own channel influxdata/influxdb
1 participant
@pauldix