Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodejs-mobile in nj-cli build #163

Open
staltz opened this issue Jun 7, 2021 · 3 comments
Open

Support nodejs-mobile in nj-cli build #163

staltz opened this issue Jun 7, 2021 · 3 comments
Labels
build CI documentation Improvements or additions to documentation platform/mobile

Comments

@staltz
Copy link

staltz commented Jun 7, 2021

With a few tweaks, node-bindgen actually supports iOS and Android via nodejs-mobile.

I don't have time available and knowledge of this codebase enough to submit a PR, but if you (maintainers) want to support nodejs-mobile, then it's a low-hanging fruit since you can just follow the steps I implemented here:

https://github.com/ssb-ngi-pointer/ssb-validate2-rsjs-node/blob/289a6bd92d651d6d97cf07f89d6325ba82686d80/install.js#L33-L44

Thanks for node-bindgen!

@staltz staltz changed the title Support nodejs-mobile Support nodejs-mobile in nj-cli build Jun 7, 2021
@sehz
Copy link
Collaborator

sehz commented Jun 7, 2021

Great. We will certainly take look at support mobile OS. @simlay What do you think?

@mkawalec
Copy link
Contributor

This looks deceptively simple. I don't have much time on my hands either, but I would also want this implemented. @staltz do you know of a good testing PoC to verify things work correctly?

@staltz
Copy link
Author

staltz commented Jun 16, 2021

@mkawalec Unfortunately I don't have a simple setup to recommend, but I maintain manyverse which uses node-bindgen (indirectly) in the branch validate2.

To keep it easy for you, I suggest you just try coding the changes in node-bindgen on a separate branch (of node-bindgen) and then you can ask me to test it out. I can just point my dependencies to your git branch of node-bindgen.

@sehz sehz added build CI documentation Improvements or additions to documentation platform/mobile labels Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI documentation Improvements or additions to documentation platform/mobile
Projects
None yet
Development

No branches or pull requests

3 participants