Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version without leading v fails check #252

Open
DanielMSchmidt opened this issue Dec 5, 2019 · 2 comments
Open

Version without leading v fails check #252

DanielMSchmidt opened this issue Dec 5, 2019 · 2 comments

Comments

@DanielMSchmidt
Copy link
Contributor

I have a check for kind 0.6.1 which has the kind --version output of kind version 0.6.1. It fails with ✖ No version was detected from the output of the binary 'kind'

When kind was in version 0.5.1 the output was kind version v0.5.1, which was parsed successfully.

My rule definition is

{
  "$schema": "http://json.schemastore.org/solidaritySchema",
  "requirements": {
    "Node": [
      {
        "rule": "cli",
        "binary": "node",
        "semver": ">= 12.9.1"
      }
    ],
    "kind": [
      {
        "rule": "cli",
        "binary": "kind",
        "semver": "0.6.1"
      }
    ],
  }
}
@GantMan
Copy link
Member

GantMan commented Dec 7, 2019

Hrmmm, seems like the regex is getting messed up by the v
This code should have fixed it: https://github.com/infinitered/solidarity/blob/master/src/extensions/functions/removeNonVersionCharacters.ts

Let me dig deeper

@GantMan
Copy link
Member

GantMan commented Dec 7, 2019

Can you verify kind -v fails? BC if it doesn't that's the problem. It tries -v first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants