-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INCLUDEPY is incorrect #374
Comments
We could also update the libraries to get the include path from |
PyO3 uses NumPy uses it here: https://github.com/numpy/numpy/blob/dc862b43e3bca09dcf5c235c46b2c7573e2e4b80/numpy/testing/_private/extbuild.py#L109 I don't know the history here or why this particular variable gets picked up so much. |
Thanks for the report. I wonder how |
I stepped through the standard library in a debugger. It looks like
I can certainly make a PyO3 patch that checks |
Thank you! That makes sense to me. The alternative is to change the |
If it can be changed at install time I think that would be best, there's a lot of code out there checking for INCLUDEPY: https://github.com/search?q=INCLUDEPY&type=code |
Related astral-sh/uv#7369 |
Opened astral-sh/uv#8429 to track this |
I'm experimenting with using a python-build-standalone python executable in CI on some projects like PyO3 and NumPy and am running into some issues.
The biggest one so far is that
INCLUDEPY
points to a non-existent path:This makes it difficult to build C extensions against this version of Python, since it looks like libraries tend to check INCLUDEPY.
Interestingly,
include
is fine:I see that there is prior discussion about these
/install
paths being hard to update, although maybe since one path is updated we can update INCLUDEPY?The text was updated successfully, but these errors were encountered: