Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit existing tests, get back to green, and add more tests #1272

Open
4 tasks
drusepth opened this issue May 15, 2023 · 0 comments
Open
4 tasks

Audit existing tests, get back to green, and add more tests #1272

drusepth opened this issue May 15, 2023 · 0 comments

Comments

@drusepth
Copy link
Member

drusepth commented May 15, 2023

Expected behavior

  • Our test suite should be green.
    • After the test suite is green, we should lock the master branch and require all new contributions through green PRs.
  • Test coverage should cover a larger percentage of the codebase.
  • Tests should only fail for functional errors; not frontend/design changes.

Actual behavior

  • Most tests are commented out, aren't quality tests, and/or extremely old and failing.
  • New tests haven't been written in many years.

Steps to reproduce the behavior

Tests can be run with the command rake test:

drusepth@perseverance:~/Code/indentlabs/notebook$ rake test
RAILS_GROUPS is unset; defaulting to web,worker
Run options: --seed 63701

# Running:
[...failures...]
..................................................................................................................................

Finished in 37.916894s, 5.3011 runs/s, 17.7757 assertions/s.
201 runs, 674 assertions, 0 failures, 2 errors, 0 skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant