Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-274: Optimize Timer creation #529

Merged
merged 11 commits into from
Feb 5, 2025

IWF-274: consolidate debug query methods

06500dc
Select commit
Loading
Failed to load commit list.
Merged

IWF-274: Optimize Timer creation #529

IWF-274: consolidate debug query methods
06500dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2025 in 1s

65.70% (+1.03%) compared to 2d552b8

View this Pull Request on Codecov

65.70% (+1.03%) compared to 2d552b8

Details

Codecov Report

Attention: Patch coverage is 93.12321% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.70%. Comparing base (2d552b8) to head (06500dc).

Files with missing lines Patch % Lines
service/interpreter/timers/greedyTimerProcessor.go 92.59% 7 Missing and 1 partial ⚠️
service/interpreter/timers/greedyTimerScheduler.go 93.75% 3 Missing and 2 partials ⚠️
service/interpreter/cadence/workflowProvider.go 85.71% 3 Missing ⚠️
service/interpreter/queryHandler.go 72.72% 2 Missing and 1 partial ⚠️
service/interpreter/temporal/workflowProvider.go 91.66% 2 Missing ⚠️
service/interpreter/activityImpl.go 88.88% 1 Missing ⚠️
service/interpreter/timers/simpleTimerProcessor.go 94.11% 1 Missing ⚠️
service/interpreter/workflowImpl.go 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   64.66%   65.70%   +1.03%     
==========================================
  Files          59       62       +3     
  Lines        6639     6849     +210     
==========================================
+ Hits         4293     4500     +207     
- Misses       2067     2068       +1     
- Partials      279      281       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov