Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace formatted translatable strings with templates for better flexibility #127

Open
LilyFoote opened this issue Aug 4, 2015 · 1 comment
Open

Replace formatted translatable strings with templates for better flexibility #127

LilyFoote opened this issue Aug 4, 2015 · 1 comment
Labels
enhancement

Comments

@LilyFoote
Copy link
Contributor

The password_reset_email_handler and validation_email_handler each define a subject that is formatted with the site.domain. This is difficult to override when the domain is unwanted.

We could instead use a django template, to which we pass the site.domain in a context. This would allow a project to replace the subject completely, ignoring the context.
@kevinetienne
Copy link
Contributor

Can the subject be passed through the notification? Or be overridden by the notification if present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinetienne @LilyFoote