Token Popup not working on new repeater rows.

[atwellpub]

Created issue here:
vadimsva/popModal#15

[DavidWells]

The popups and ACF repeater fields are probably added after dom loaded

You have to attach the handler like this:

jQuery("body").on('click', '.dynamic-element', function () {

});

Not sure how the library handles this.

Why did you choose: http://vadimsva.github.io/popModal/ ? The styles look not so great

[atwellpub]

We are handing it with the 'On', but it's still not working, which makes me think it might be an issue with popModal.

https://github.com/inboundnow/inbound-mailer/blob/master/classes/class.token-engine.php#L143-L158

I needed a simple and lightweight modal class that could be styled easily. How it is used I thinks looks decent : /

[DavidWells]

Yeah that looks okay. I was looking at the libraries demo.

I guess the main thing is when we are adding new libs to the code base that we don't duplicate functionality.

We have the old old old popover thing for other settings pages too. We should remove the old stuff when adding new stuff that does the same thing

On Sep 25, 2015, at 12:39 PM, Hudson Atwell [email protected] wrote:

We are handing it with the 'On', but it's still not working, which makes me think it might be an issue with popModal.

https://github.com/inboundnow/inbound-mailer/blob/master/classes/class.token-engine.php#L143-L158

I needed a simple and lightweight modal class that could be styled easily. How it is used I thinks looks decent : /

—
Reply to this email directly or view it on GitHub.

[DavidWells]

PS there is a fix for that ACF warning:
http://support.advancedcustomfields.com/forums/topic/wp_htmledit_pre-is-deprecated/

On Fri, Sep 25, 2015 at 12:39 PM, Hudson Atwell [email protected]
wrote:

We are handing it with the 'On', but it's still not working, which makes
me think it might be an issue with popModal.

https://github.com/inboundnow/inbound-mailer/blob/master/classes/class.token-engine.php#L143-L158

I needed a simple and lightweight modal class that could be styled easily.
How it is used I thinks looks decent : /

https://camo.githubusercontent.com/b60b6b16186b9e7809017cd492201491b0ba7460/687474703a2f2f636f6e74656e742e73637265656e636173742e636f6d2f75736572732f6164626f782f666f6c646572732f4a696e672f6d656469612f65613734356366622d303166352d343461652d386631652d6466386365343234323962642f323031352d30392d32355f313433392e706e67

—
Reply to this email directly or view it on GitHub
#57 (comment)
.