port write_dwc() to use API

[PietrH]

Base on vcr branch and immediately implement cached API responses for tests

• deprecate connection
• split tests: local connection
• split tests: api
• check_opencpu_response() should check for content type of API response #300
• cache API response
• implement sql helper
• test sql helper
• update NEWS?
• deprecate directory
• reinstate directory
• ignore passing directory to helper functions: add ignore_arguments argument to conduct_parent_to_helpers()
• setup optional writing functionality after conduct_parent_to_helpers()
• make sure write_dwc(api = TRUE) uses RDS/compression
• Check if I can use DBI::dbDisconnect() after all, it seems to work for the other functions, so why not here?
• move tests to single file
• R CMD CHECK fails on v2.3 #307

[PietrH]

write_dwc() is the only function that has a deprecated argument other than connection: directory, this argument is passed in the payload and causing an invalid request to openCPU.

This is because the arguments that should not be passed to the API are hardcoded in the conduct_parent_to_helpers() function:

etn/R/utils.R

Lines 354 to 362 in ee49b2d

	# Get the argument values from the parent function
	arguments_to_pass <-
	return_parent_arguments(depth = 2)[
	!names(return_parent_arguments(depth = 2)) %in% c(
	"api",
	"connection",
	"function_identity"
	)
	]

It might be better if deprecated arguments could be explicitly passed to this function as arguments, the api argument should never be passed to etnservice

[PietrH]

I can use DBI::dbDisconnect() here, and everywhere, because a connection is created for every query, and then closed again after the query.

In etnservice we had a connection leak causing too much resources to be used and the database to run out of connections. However, there might be a performance penalty.

I'm leaving it in for now.