Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore non-exported functions on max_function_arity #309

Open
elbrujohalcon opened this issue Mar 7, 2023 · 3 comments
Open
Milestone

Comments

@elbrujohalcon
Copy link
Member

Is your feature request related to a problem? Please describe

Private functions having too many arguments are not as much of a problem as exported ones. They should not be judged too severely.

Describe the solution you'd like

I would add a parameter like…

  • non_exported_max_arity :: pos_integer()

…with a very very large default value (e.g. 20)

Describe alternatives you've considered

An alternative would be to just ignore non-exported functions or have a flag like apply_to :: exported | non_exported | both that defaults to exported. But I think my proposal above is more flexible.

@elbrujohalcon elbrujohalcon added this to the 3.0.1 milestone Mar 7, 2023
@paulo-ferraz-oliveira
Copy link
Collaborator

I'd simply ignore the private functions (but yeah, going with a super-high default might not hurt, either). Once they're exposed the rule kicks in and changes might be in order.

@elbrujohalcon elbrujohalcon modified the milestones: 3.0.1, 4.1.0 Sep 16, 2024
@elbrujohalcon elbrujohalcon modified the milestones: 4.1.0, 4.0.0 Nov 13, 2024
@bormilan
Copy link
Contributor

bormilan commented Dec 1, 2024

I don't know which one is better, but from the name of the issue, I assume that you want to add the ignoring version first based on @elbrujohalcon's alternative idea.

@paulo-ferraz-oliveira
Copy link
Collaborator

Yeah, we seem to want non_exported_max_arity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants