Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't crawl libraries with import paths containing quote symbols #14588

Closed
1 of 3 tasks
om-hb opened this issue Dec 8, 2024 · 3 comments · Fixed by #14856
Closed
1 of 3 tasks

Can't crawl libraries with import paths containing quote symbols #14588

om-hb opened this issue Dec 8, 2024 · 3 comments · Fixed by #14856
Assignees

Comments

@om-hb
Copy link

om-hb commented Dec 8, 2024

The bug

Hi there!

First, thank you for creating Immich! It has been fantastic to use, and I appreciate all the hard work you’ve put into it.

The Issue
I noticed that some of my images are missing from my library. Upon further inspection, it seems that files in import paths containing apostrophes (like /path/to/John's Photos) aren’t being indexed. These files don’t show up in the library even though the paths are valid and accessible.

I create this little example to check if my suspicion was correct:
sc_immich
Both folders contain similar images, however, only the images from "/bilder/Test/" are added to my library.

The OS that Immich Server is running on

Debian

Version of Immich Server

v1.122.1

Version of Immich Mobile App

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

name: immich

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.transcoding.yml
    #   service: cpu # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    volumes:
      # Do not edit the next line. If you want to change the media storage location on your system, edit the value of UPLOAD_LOCATION in the .env file
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
      - /srv/XXXXX/XXXX/Bilder:/bilder
    env_file:
      - stack.env
    ports:
      - '2283:2283'
    depends_on:
      - redis
      - database
    restart: always
    healthcheck:
      disable: false

  immich-machine-learning:
    container_name: immich_machine_learning
    # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.
    # Example tag: ${IMMICH_VERSION:-release}-cuda
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration
    #   file: hwaccel.ml.yml
    #   service: cpu # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable
    volumes:
      - model-cache:/cache
    env_file:
      - stack.env
    restart: always
    healthcheck:
      disable: false

  redis:
    container_name: immich_redis
    image: docker.io/redis:6.2-alpine@sha256:2ba50e1ac3a0ea17b736ce9db2b0a9f6f8b85d4c27d5f5accc6a416d8f42c6d5
    healthcheck:
      test: redis-cli ping || exit 1
    restart: always

  database:
    container_name: immich_postgres
    image: docker.io/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      POSTGRES_INITDB_ARGS: '--data-checksums'
    volumes:
      # Do not edit the next line. If you want to change the database storage location on your system, edit the value of DB_DATA_LOCATION in the .env file
      - ${DB_DATA_LOCATION}:/var/lib/postgresql/data
    healthcheck:
      test: pg_isready --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' || exit 1; Chksum="$$(psql --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' --tuples-only --no-align --command='SELECT COALESCE(SUM(checksum_failures), 0) FROM pg_stat_database')"; echo "checksum failure count is $$Chksum"; [ "$$Chksum" = '0' ] || exit 1
      interval: 5m
      start_interval: 30s
      start_period: 5m
    command:
      [
        'postgres',
        '-c',
        'shared_preload_libraries=vectors.so',
        '-c',
        'search_path="$$user", public, vectors',
        '-c',
        'logging_collector=on',
        '-c',
        'max_wal_size=2GB',
        '-c',
        'shared_buffers=512MB',
        '-c',
        'wal_compression=on',
      ]
    restart: always

volumes:
  model-cache:

Your .env content

UPLOAD_LOCATION=./library
DB_DATA_LOCATION=./postgres
IMMICH_VERSION=release
DB_PASSWORD=XXXX
DB_USERNAME=XXXX
DB_DATABASE_NAME=immich

Reproduction steps

  1. Add an external library
  2. Add an import path containing an apostrophe
  3. Try to index the external library

Relevant log output

No response

Additional information

No response

@flyotlin
Copy link
Contributor

flyotlin commented Dec 9, 2024

I can reproduce what you described, external library with apostrophe (') in path are not indexed (scanned).

Are you currently working on solving this?

@om-hb
Copy link
Author

om-hb commented Dec 13, 2024

I can reproduce what you described, external library with apostrophe (') in path are not indexed (scanned).

Are you currently working on solving this?

No, sadly I'm lacking the required skills to fix this on my own.

@etnoy
Copy link
Contributor

etnoy commented Dec 19, 2024

Thanks for your report, I'll look into this

@etnoy etnoy self-assigned this Dec 19, 2024
@etnoy etnoy changed the title External Libraries: Files from Import Paths containing apostrophes are not indexed Can't crawl libraries with import paths containing quote symbols Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants