Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Shared links back navigation button navigates to wrong page #11985

Open
1 of 3 tasks
Snowknight26 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #13703
Open
1 of 3 tasks

Web: Shared links back navigation button navigates to wrong page #11985

Snowknight26 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #13703

Comments

@Snowknight26
Copy link
Contributor

Snowknight26 commented Aug 23, 2024 •
edited
Loading

The bug

The back/close button on the Shared links page seems to be hard-coded to always go back to /sharing instead of where you previously were.

The OS that Immich Server is running on

Windows 10 22H2 (19045.4780)

Version of Immich Server

v1.112.1

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

  1. Go to Photos
  2. Click on a photo
  3. Click the triple dots on the top navigation bar
  4. Click Add to album
  5. Click New Album
  6. Click View Album in the toast, or click the album in the Info bar
  7. Click Share in the top nav bar
  8. Click Create link
  9. Click Create link
  10. Close the modal
  11. Click Share in the top nav bar
  12. Click View links
  13. Click the Close button (back icon) in the top nav bar

You should be back on the album, not back on Sharing

Relevant log output

No response

Additional information

No response
@Pranay-Pandey Pranay-Pandey linked a pull request Oct 23, 2024 that will close this issue
Open
@Pranay-Pandey
Copy link
Contributor

@jrasm91 Can you please suggest if this is the correct way to handle this? I see your comment

  // The GalleryViewer pushes it's own history state, which causes weird
  // behavior for history.back(). To prevent that we store the previous page
  // manually and navigate back to that.

Would using history.back() in albums/album-id be bad?

Or is this redirect hardcoded in sharing/sharedlinks for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Routing back button in sharedLinks page Pranay-Pandey/immich
2 participants
@Snowknight26 @Pranay-Pandey