Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device no longer recognized since version > 0.9.36 #290

Open
cloud4every1 opened this issue Oct 30, 2017 · 8 comments
Open

Device no longer recognized since version > 0.9.36 #290

cloud4every1 opened this issue Oct 30, 2017 · 8 comments

Comments

@cloud4every1
Copy link

I'm using Aframe 0.7.0 and my device is no longer recognized with this version.
navigator.getVRDisplays() does no longer return anything.
With version 0.6.1 the same command returned Array(1) 0 : CardboardVRDisplay bufferScale_ : 1 cardboardUI_ : null deviceInfo_ : DeviceInfo displayName : "Cardboard VRDisplay (webvr-polyfill)" distorter_ : null dpdb_ : Dpdb poseSensor_ : FusionPoseSensor viewerSelector_ : ViewerSelector __proto__ : VRDisplay

The intermediate solution currently is to change the dependency from "webvr-polyfill": "^0.9.36" to "webvr-polyfill": "0.9.36" and generated a new js file. Issue was open also for A-Frame #3190

The device is an Epson Moverio BT-300 with Android 5.1

@jsantell
Copy link
Contributor

Thanks for reporting! Do you know if 0.9.36 is the latest version that works for you?

Linking to the aframe issue: aframevr/aframe#3190

@cloud4every1
Copy link
Author

Sorry for the delay.

I'm sorry I do not have the files any more. I'm pretty sure but I have overwritten the js file I have compiled and tested.
At that time I tested the problem with the provided aframe 0.6.1 version - which was working. The package.json contains "webvr-polyfill": "^0.9.36".
I recompiled it my self and it was no longer working.
So I checked the version in the js file and this one (the working version) did contain the 0.9.36 while the recompiling one contained ( I think it was 0.9.37 or 38) which did not work. Now Aframe contains 0.9.40.

jdbolter added a commit to jdbolter/train-demo that referenced this issue Dec 9, 2017
I tried updating to aframe 7.1. Everything seems to work, but the problem that look controls do not work persists. This may or may not have anything to do with the bug reported: immersive-web/webvr-polyfill#290
@jsantell
Copy link
Contributor

Parsing the differening JSONs used, the only ones added (none were removed) between the two versions are the ones documented in the dpdb change log:

  • Lenovo PB2-690Y
  • Moto G (5) Plus
  • SM-N920P
  • SM-G950F
  • SM-G955U
  • IQ4412

That being said, even if your device is unable to be found, there still should be a VRDisplay. I believe the large change for the 0.10.0 release will have ensured this fix with different configurations affecting the number of VRDisplays returned, but will need a PR to A-Frame to fix this first

@siva3378
Copy link

This issue still exists in [email protected] & [email protected]. Any ideas/suggestions how to fix this?

@jsantell
Copy link
Contributor

If a device was previously found in older versions of the polyfill, but is no longer found, I'd like to see the device info from before to learn why it is no longer being matched. No devices have been removed from the DB, so could be a matching issue.

@juliovedovatto
Copy link

Same problem here.

webvr-polyfill does not play well with Firefox (Windows) after v0.9.36. I'm using google vrview on a website. I had to change vrviews's packages.json to use [email protected] instead. Then it worked again.

I preferred to report on this issue, because it is almost the same problem @cloud4every1 mentioned.

@jsantell
Copy link
Contributor

This is the logic used to match devices; devices have not been removed from there, and even if no device match is found, default values will be produced for the cardboard viewer when viewing on mobile. That being said, it looks like the issue is no VRDisplays are produced, correct?

What happens when viewing the example on mobile? What happens when pressing the "VR" button in the upper right corner?

@jsantell
Copy link
Contributor

If you could try debugging on the device and find out why a CardboardVRDisplay isn't being created, this is the class that creates and determines if a VRDisplay can be created, I'd be curious where this fails on your device. If you could also share your navigator.userAgent string, that'd be helpful as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants