Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] parameter split error with generics #46

Open
Tsuk1ko opened this issue Apr 16, 2021 · 1 comment
Open

[JavaScript] parameter split error with generics #46

Tsuk1ko opened this issue Apr 16, 2021 · 1 comment

Comments

@Tsuk1ko
Copy link

Tsuk1ko commented Apr 16, 2021

image

The third parameter should be accumulator. It seems that the comma in generics make parameter splitting wrong.

@AnthonyLenglet
Copy link

AnthonyLenglet commented Jun 28, 2021

Confirming that something is wrong with the way its parsing the definition of the function, in the case shwon below, it should pick up op2, and it is picking up Project right before it instead

image

trying to add a parameter after this confirms this by calling it op2

image

I'm guessing the issue resides in this split right here
https://github.com/imliam/vscode-inline-parameters/blob/master/src/drivers/abstract-javascript.ts#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants