style: improve code style according to @mikecovlee

Signed-off-by: imkiva <[email protected]>

Author: imkiva

include/kivm/bytecode/bytecodeInterpreter.h

@@ -9,7 +9,7 @@
 #include <kivm/runtime/javaThread.h>
 
 namespace kivm {
-    class ByteCodeInterpreter {
+    class ByteCodeInterpreter final {
     public:
         /**
          * Run a thread method

include/kivm/bytecode/codeBlob.h

@@ -6,7 +6,7 @@
 #include <kivm/kivm.h>
 
 namespace kivm {
-    class CodeBlob {
+    class CodeBlob final {
         friend class Method;
 
     private:

include/kivm/bytecode/execution.h

@@ -20,7 +20,7 @@
 #define T_LONG                 11
 
 namespace kivm {
-    class Resolver {
+    class Resolver final {
     public:
         static oop javaOop(jobject obj);
 
@@ -43,7 +43,7 @@ namespace kivm {
      * Each country has an execution officer,
      * and virtual machines are no exception.
      */
-    class Execution {
+    class Execution final {
     public:
         static oop invokeInterface(JavaThread *thread, RuntimeConstantPool *rt,
                                    Stack &stack, int constantIndex, int count);

include/kivm/bytecode/javaCall.h

@@ -7,7 +7,7 @@
 #include <list>
 
 namespace kivm {
-    class JavaCall {
+    class JavaCall final {
     private:
         JavaThread *_thread;
         Method *_method;

include/kivm/bytecode/threadedInterpreter.h

@@ -20,7 +20,7 @@ namespace kivm {
 
     class InstanceKlass;
 
-    class ThreadedInterpreter {
+    class ThreadedInterpreter final {
     public:
         /**
          * Run a thread method

include/kivm/classfile/classFile.h

@@ -112,24 +112,24 @@ namespace kivm {
         void init(ClassFileStream &stream, cp_info **constant_pool);
     };
 
-    struct ClassFile {
+    struct ClassFile final {
         /**
          * The magic item supplies the magic number identifying the class file format.
          * It has the value 0xCAFEBABE.
          */
-        u4 magic;
-        u2 minor_version;
-        u2 major_version;
+        u4 magic{};
+        u2 minor_version{};
+        u2 major_version{};
 
-        u2 constant_pool_count;
+        u2 constant_pool_count{};
 
         /**
          * The constant_pool table is indexed
          * from {@code 1} to {@code constant_pool_count - 1}.
          */
-        cp_info **constant_pool;
+        cp_info **constant_pool = nullptr;
 
-        u2 access_flags;
+        u2 access_flags{};
 
         /**
          * The value of the {@code this_class} item must be
@@ -138,7 +138,7 @@ namespace kivm {
          * a {@code CONSTANT_Class_info} structure (§4.4.1)
          * representing the class or interface defined by this class file.
          */
-        u2 this_class;
+        u2 this_class{};
 
         /**
          * For a class, the value of the {@code super_class} item either must
@@ -147,18 +147,18 @@ namespace kivm {
          * a {@code CONSTANT_Class_info} structure representing
          * the direct superclass of the class defined by this class file.
          */
-        u2 super_class;
+        u2 super_class{};
 
-        u2 interfaces_count;
-        u2 *interfaces;
+        u2 interfaces_count{};
+        u2 *interfaces = nullptr;
 
-        u2 fields_count;
-        field_info *fields;
+        u2 fields_count{};
+        field_info *fields = nullptr;
 
-        u2 methods_count;
-        method_info *methods;
+        u2 methods_count{};
+        method_info *methods = nullptr;
 
-        u2 attributes_count;
-        attribute_info **attributes;
+        u2 attributes_count{};
+        attribute_info **attributes = nullptr;
     };
 }

include/kivm/classfile/classFileParser.h

@@ -8,16 +8,16 @@
 #include <kivm/classfile/classFileStream.h>
 
 namespace kivm {
-    class ClassFileParser {
+    class ClassFileParser final {
     public:
         static ClassFile *alloc();
 
         static void dealloc(ClassFile *class_file);
 
     private:
-        ClassFile *_classFile;
+        ClassFile *_classFile = nullptr;
         ClassFileStream _classFileStream;
-        u1 *_content;
+        u1 *_content = nullptr;
         size_t _size;
 
         ClassFile *parse();

include/kivm/classfile/classFileStream.h

@@ -23,13 +23,13 @@ namespace kivm {
      *  The entire input stream is present in a buffer allocated by the caller.
      *  The caller is responsible for deallocating the buffer.
      */
-    class ClassFileStream {
+    class ClassFileStream final {
     private:
-        u1 *_bufferStart; // Buffer bottom
-        u1 *_bufferEnd;   // Buffer top (one past last element)
-        u1 *_current;      // Current buffer position
+        u1 *_bufferStart = nullptr; // Buffer bottom
+        u1 *_bufferEnd = nullptr;   // Buffer top (one past last element)
+        u1 *_current = nullptr;      // Current buffer position
         String _source;    // Source of stream (directory name, ZIP/JAR archive name)
-        bool _needVerify;  // True if verification is on for the class file
+        bool _needVerify{};  // True if verification is on for the class file
 
         void guaranteeMore(int size) {
             auto remaining = (size_t) (_bufferEnd - _current);
@@ -40,7 +40,7 @@ namespace kivm {
         }
 
     public:
-        ClassFileStream();
+        ClassFileStream() = default;
 
         void init(u1 *buffer, size_t length);
 

include/kivm/classpath/classPathManager.h

@@ -13,25 +13,25 @@ namespace kivm {
         JAR
     };
 
-    struct ClassSearchResult {
+    struct ClassSearchResult final {
         String _file;
-        int _fd;
+        int _fd{};
         ClassSource _source;
-        u1 *_buffer;
-        size_t _bufferSize;
+        u1 *_buffer = nullptr;
+        size_t _bufferSize{};
 
         ClassSearchResult(const String &file, int fd, ClassSource source, u1 *buffer, size_t bufferSize);
 
         void closeResource() const;
     };
 
-    struct ClassPathEntry {
+    struct ClassPathEntry final {
         ClassSource _source;
         String _path;
         void *_cookie;
     };
 
-    class ClassPathManager {
+    class ClassPathManager final {
     private:
         std::list<ClassPathEntry> _runtimeClassPath;
 

include/kivm/classpath/system.h

@@ -10,7 +10,7 @@
 namespace kivm {
     class Klass;
 
-    class SystemDictionary {
+    class SystemDictionary final {
     private:
         HashMap<String, Klass *> _classes;
         Lock _lock;