Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #129

Open
zamazan4ik opened this issue Oct 23, 2024 · 0 comments
Open

Enable Link-Time Optimization (LTO) #129

zamazan4ik opened this issue Oct 23, 2024 · 0 comments

Comments

@zamazan4ik
Copy link

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I have made quick tests (Fedora 40) by adding lto = true to the Release profile. The binary size reduction is the following:

  • shiva: from 42 Mib to 34 Mib
  • server: from 41 Mib to 33 Mib

Thank you.

P.S. By the way, if you are interested in gaining additional performance wins for the binaries, I can kindly suggest you evaluate optimizing Shiva binaries with more advanced optimization techniques like Profile-Guided Optimization (PGO) and Post-Link Optimization (PLO) (the most common tool for that is LLVM BOLT nowadays). According to my tests in awesome-pgo PGO highly-likely should work fine with Shiva since PGO is especially good in optimizing different parsing routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant