Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log replace println! #101

Open
evgenyigumnov opened this issue Jul 2, 2024 · 0 comments
Open

log replace println! #101

evgenyigumnov opened this issue Jul 2, 2024 · 0 comments

Comments

@evgenyigumnov
Copy link
Member

Could you remove all of println?

Add "log = "0.4.20" to Cargo.toml please

Probably better way to inform about problems should look like this:

log::warn!("No align value for image");

you should understand what for printing logs you could use other crate

for example "env_logger = "0.10.0""

please add this create only for tests like a developer dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Shiva library
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joserochadocarmo @evgenyigumnov