From e0ccacea6576c56eb9042e3091570f101af46dbe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Rom=C3=A1n?= Date: Tue, 27 Feb 2024 12:58:36 -0800 Subject: [PATCH] build: update pre-commit pylint hook (#190) when pylint is installed isolated from pre-commit, e.g. with pipx, it flags setup.py with E0401 since setuptools is not found update tox config --- .pre-commit-config.yaml | 1 + README.md | 6 +++--- tox.ini | 12 +----------- 3 files changed, 5 insertions(+), 14 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 62c3c1a..f1b4f0f 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -34,4 +34,5 @@ repos: name: pylint entry: pylint language: system + files: ^src/ types: [python] diff --git a/README.md b/README.md index bc5c443..7cf62f7 100644 --- a/README.md +++ b/README.md @@ -89,11 +89,11 @@ To install incendium on your Gateway follow these steps: 1. If you're replacing a previous version, make sure to check Allow Overwrite 1. Click on **Import** -Alternatively you could follow the instructions for cloning the `project` branch directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/incendium/tree/project#cloning-this-branch). +Alternatively you could follow the instructions for cloning the `project` repo directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/project?tab=readme-ov-file#cloning-this-repo). ## Contributing to `incendium` -See [CONTRIBUTING.md](./CONTRIBUTING.md). +See [CONTRIBUTING.md](https://github.com/ignition-incendium/.github/blob/main/CONTRIBUTING.md#contributing-to-incendium). ## Discussions @@ -111,4 +111,4 @@ See [LICENSE](./LICENSE). ## Code of conduct -See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md). +See [CODE_OF_CONDUCT.md](https://github.com/ignition-incendium/.github/blob/main/CODE_OF_CONDUCT.md). diff --git a/tox.ini b/tox.ini index 43987d0..bf6984a 100644 --- a/tox.ini +++ b/tox.ini @@ -8,11 +8,10 @@ env_list = [testenv:install] description = install package -base_python = {[py2]base_python} +base_python = python2.7 [testenv:typecheck] description = run type check on code base -base_python = {[type]base_python} skip_install = true deps = {[type]deps} @@ -21,7 +20,6 @@ commands = [testenv:stubgen] description = generate stubs -base_python = {[type]base_python} skip_install = true deps = {[type]deps} @@ -30,7 +28,6 @@ commands = [testenv:style] description = apply style -base_python = {[py3]base_python} skip_install = true deps = black @@ -49,13 +46,6 @@ commands = allowlist_externals = bash -[py2] -base_python = python2.7 - -[py3] -base_python = python3.12 - [type] -base_python = {[py3]base_python} deps = ignition-api-stubs