-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark update and correction #844
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The window of VCardEditor is now centered to the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This other code relate to : Prohibit modification of user profile but only allow the avatar change that can be very useful in case of use of LDAP / Active Directory from default.properties .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Real time save settings of window size and position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The window of InvitationDialog is now centered to the screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The window RoomCreationDialog is now centered to the screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Change Nickname button can be disabled from default.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Conference Settings button can be disabled from default.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Conference Settings window is better adjusted on the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The window of HistoryTranscrip (chat history) is larger and adapted to the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The windows of ScratchPadPlugin (Notes and Tasks) are larger and adapted to the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : The window of UserSearchService (Search Window) is larger and adapted to the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Full JID address can be showed instead of the username when hovering with the mouse cursor over a user in the contact list, from default.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code relate to : Profile Lookup can be disabled from default.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin Battleships.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin fastpath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin jingle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin meet (Pade Meeting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation update of plugin OTR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation update of plugin ROAR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin SIP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation update of plugin speeling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation of plugin tictactoe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation update of plugin transferguard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
French translation update of Spark.
I have commented out all the changed files, it should be easy to find the changes. The modifications are quite simple. |
It would be difficult to review the PR because it has many changes. You used manual upload of files. Generally speaking you should try to learn how to use the git version control system. With the git you can change many files then "commit" the change to a history (git log). For the commit you must specify a description what was changed for why. |
Hello,
Here are the changes made that have been tested:
Review of French translation of Spark and Transfer Guard Plugin to be a little more professional in case of use in enterprise. French translation added or updated regarding:
A correction was made: If the option DISABLE_EXIT is set to true, all windows size and position are not stored in the file “layout.settings” because Spark application is killed when a user logout or reboot the computer. All windows size and position are now saved in real time when a user made a change.
All new options available from default.properties have been planned and can be used in the future from the client management on OpenFire (plugin Manager/Enterprise) but disabled by default because must be implemented on the future version of OpenFire server. For the moment, the new options works only from default.properties file.
I hope that these corrections and adaptations made will be present in the new release of Spark.
Bests regards.