Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the settings are not saved #239

Open
imlunek opened this issue Oct 31, 2020 · 8 comments
Open

Some of the settings are not saved #239

imlunek opened this issue Oct 31, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@imlunek
Copy link

imlunek commented Oct 31, 2020

Describe the bug🐛
I am using catalina and iglance version 2.1 and did changes on the settings. Some of them are not saved. I am not sure if it is a bug or happening due to some limitations.

To Reproduce
Steps to reproduce the behavior:

  1. Click on any iGlance icon

  2. Click on 'Show Window'

  3. Click on 'Battery'

  4. Make sure 'Show battery symbol on menu bar' is checked

  5. Select 'Show' to 'Remaining Time' (Setting 1)

  6. Click on 'Settings

  7. Check 'Autostart on Boot' (Setting 2)

  8. Click on any iGlance icon

  9. Click 'Quit iGlance'

  10. Press 'Command + Space'

  11. Type 'iGlance' and press 'return'

Recheck the above 2 settings, they reset back to defaults. I am not sure if the issue exists on some of other settings as well.

Expected behavior
Those settings were supposed to be saved.

Desktop (please complete the following information):

  • MacOS Version: 10.15.7
  • Version of the app: 2.1
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 31, 2020
@wuyuankai
Copy link

I also have this bug, running big sur system

@chetanpm
Copy link

chetanpm commented Mar 15, 2021

For me, 'show low battery notification at' value resets to 80% on quitting and restarting the application. Iglance autostarts with the operating system boot and both show low battery and high battery notification resets to 80% even when the low is set at 30% and the high at 80% before shutdown.

@moritzcorpus
Copy link

moritzcorpus commented Mar 20, 2021

same here & additional info see below:

Describe the bug🐛
I am using catalina and iglance version 2.1 and did changes on the settings. Some of them are not saved. I am not sure if it is a bug or happening due to some limitations.

To Reproduce
Steps to reproduce the behavior:

1. Click on any iGlance icon

2. Click on 'Show Window'

3. Click on 'Battery'

4. Make sure 'Show battery symbol on menu bar' is checked

5. Select 'Show' to 'Remaining Time' (Setting 1)

6. Click on 'Settings

7. Check 'Autostart on Boot' (Setting 2)

8. Click on any iGlance icon

9. Click 'Quit iGlance'

10. Press 'Command + Space'

11. Type 'iGlance' and press 'return'

Recheck the above 2 settings, they reset back to defaults. I am not sure if the issue exists on some of other settings as well.

Expected behavior
Those settings were supposed to be saved.

differences / additional info for bugreport:

Screenshots (Optional)
see below

Desktop (please complete the following information):

  • MacOS Version: macOS 11.2.3 (20D91)
  • CPU architecture: Intel
  • Version of the app: 2.1

Log

System Settings

  • App was installed via homebrew brew install --cask iglance --appdir="~/Applications/"
  • macOS Notification System is "always" in DND Mode
  • macOS Notification for App iGlance is set to "Off"

Screenshot 2021-03-20 at 17 20 05

@D0miH D0miH pinned this issue Mar 21, 2021
@D0miH
Copy link
Member

D0miH commented Mar 21, 2021

Hey guys,
sorry it took so long to answer...
I am busy right now and can't look into the issue. If some of you wants to look into it just give a short heads up here. I will be happy to merge a fix and release a new version 👍🏻

@BartlomiejWlodarczak
Copy link

Hello everyone!

First of all big thanks to @D0miH and all of the other collaborators for this useful app. I'm loving it.
I noticed the same buggy behavior as stated in this issue and decided to take a look into code and fix it myself.

This is my first time ever working on open source software and I'm happy that I finally decided to do it.
I'll be happy to work on iGlance again soon 😃

Here's the PR: #260

@D0miH
Copy link
Member

D0miH commented Jun 5, 2021

Thanks guys. I have merged the PR and I will release a new Version soon.

@imlunek
Copy link
Author

imlunek commented Dec 12, 2021

Hello @D0miH,
We were expecting the new release with this update. Can you please do that so that we won't need to keep changing the settings after every restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants