Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low battery notification is delivered on high battery notification value #235

Open
D0miH opened this issue Oct 11, 2020 · 2 comments · Fixed by #227
Open

Low battery notification is delivered on high battery notification value #235

D0miH opened this issue Oct 11, 2020 · 2 comments · Fixed by #227
Assignees
@D0miH
Labels
bug Something isn't working next update Features/Bugs assigned to this label will be implemented/fixed with the next update.

Comments

@D0miH
Copy link
Member

D0miH commented Oct 11, 2020

Describe the bug🐛
The low battery notification value is not correctly loaded from the user settings. Instead of loading the "low notification" value the "high notification" value is loaded.

To Reproduce

  1. Start iGlance
  2. Open settings
  3. Click on the battery settings

Expected behavior
The user defined "low notification" threshold value should be loaded from the user settings.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 11, 2020
@D0miH D0miH self-assigned this Oct 11, 2020
@D0miH D0miH added the next update Features/Bugs assigned to this label will be implemented/fixed with the next update. label Oct 11, 2020
@D0miH D0miH linked a pull request Oct 11, 2020 that will close this issue
Fixed incorrect condition for Low Battery notification #227
Merged
@flutterrausch
Copy link

Still(?) happens in 2.1 on 10.15.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D0miH D0miH

Labels
bug Something isn't working next update Features/Bugs assigned to this label will be implemented/fixed with the next update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed incorrect condition for Low Battery notification rahulsuresh-git/iGlance
2 participants
@D0miH @flutterrausch