Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display of null price tags #857

Closed
Gregsai opened this issue Dec 1, 2023 · 1 comment
Closed

Wrong display of null price tags #857

Gregsai opened this issue Dec 1, 2023 · 1 comment

Comments

@Gregsai
Copy link
Contributor

Gregsai commented Dec 1, 2023

Describe the bug

On the dashboard, when hovering over the prices of summary cards, a tag appears. However, when:

  • The price is different from 0, the tag displays the price in the format: 'currency value' (e.g., $ 300.00).
  • The price is equal to 0, the tag displays the price in the format: '0' with a misalignment of the value '(0)' to the left.

The purpose of this bug report is simply to enhance the project's aesthetics.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the 'Dashboard'.
  2. Hover over the price of a summary card that is equal to 0.
  3. Observe the tag appearance, noting the discrepancy in displaying the tag value compared to non-zero prices.

Image 1: Tag displayed while hovering over a non-null price (Correct behaviour):
image

Image 2: Tag displayed while hovering over a null price (Wrong behaviour):
image

Expected behavior
The content of tags when the value is null should be identical to tags with non-null values. Namely: 'currency value' (e.g., $ 300.00).

The following image illustrates the expected display of tags when the value is null:
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser [Brave; Edge]
  • Version [1.60.125; 119.0.2151.93]
    Additional context
@Gregsai
Copy link
Contributor Author

Gregsai commented Dec 1, 2023

I created a PR for this issue : #858

salahlalami added a commit that referenced this issue Dec 1, 2023
…to-zero

Fix: display of the tag when the value is zero #857
@Gregsai Gregsai closed this as completed Dec 16, 2023
eltonsoftware pushed a commit to eltonsoftware/idurar-erp-crm that referenced this issue May 20, 2024
…equal-to-zero

Fix: display of the tag when the value is zero idurar#857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant