APM overcounting

[veeq7]

Seems like currently all commands are being counted towards APM including system level ones like Hash (TypeIDSync) and etc

I would recommend a switch statement over baseCmd.Type.ID in replay.go:102 to determine which ones should be counted, or maybe a bool in Type in repcmd/types.go

[icza]

Please note that in the loop you refer to, all commands are inspected, but not all are counted in APM. The command must be bound to the player.

Also TypeIDSync commands are not even stored in the commands slice, so they are obviously not counted in APM. To see which commands are not stored (and thus definitely not counted), see the repparser.go file.

[icza]

On a second look, the repparser does store all commands in the Cmds slice, but as mentioned above, commands are only counted in APM if they are bound to a player.
I also checked 2 replays, one Blizzard ladder and another, neither contained a single TypeIDSync command.