Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for horizontal scrolling in ScrollWidget #238

Open
stevesoltys opened this issue Jun 4, 2020 · 5 comments
Open

Add support for horizontal scrolling in ScrollWidget #238

stevesoltys opened this issue Jun 4, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@stevesoltys
Copy link
Contributor

I am trying to implement a UIScrollView which can be scrolled horizontally.

I believe this is not currently supported, as per this comment: https://github.com/icerockdev/moko-widgets/blob/master/widgets/src/commonMain/kotlin/dev/icerock/moko/widgets/ScrollWidget.kt#L23

I may be missing something, please let me know if I am.

@stevesoltys
Copy link
Contributor Author

I was able to solve my particular case with the CollectionWidget. However, I will leave the issue open because I believe (?) it still applies.

Side question: Will the CollectionWidget become part of the regular widgets available to the project? Meaning, is it a work in progress and that's why it isn't part of the library yet?

@Alex009
Copy link
Member

Alex009 commented Jun 8, 2020

hi!
for now ScrollWidget not have configuration of orientation (but we add it later. as part of this issue).

about CollectionWidget:

  1. collection widget on iOS now work not good in case of multiple columns. but if you use one column (or one row in horizontal orientation) - all should be good
  2. collection just like list will reuse items when scroll, so you should not add any input controls into this (keyboard will be crazy in cases of reuse items at scroll)
  3. CollectionWidget placed in widgets-collection because it require additional Swift CocoaPod for iOS. core widgets module not require any additional modules. it not mean that "it's not part of library" - any of modules in this repository is part of moko-widgets. Separation by modules required for more control of applied dependencies in target application

@Alex009 Alex009 added the enhancement New feature or request label Jun 8, 2020
@Alex009 Alex009 added this to the 0.1.0-dev-20 milestone Jun 8, 2020
@stevesoltys
Copy link
Contributor Author

Thanks for the reply @Alex009.

  1. I am using one row in horizontal direction, so should be fine here.
  2. Good to know. Just showing images for now. So I think should be good there too.
  3. I see. Is this module available in Maven currently? That is what I meant by "part of the library" - I didn't see if it was being published or not. If it is available as a Maven dependency, could you point me to the artifact I should depend on? I ask because I do not see it in 0.1.0-dev-19 currently.

@Alex009
Copy link
Member

Alex009 commented Jun 9, 2020

@stevesoltys yes, it's available in maven - https://bintray.com/icerockdev/moko/moko-widgets/0.1.0-dev-19#files/dev%2Ficerock%2Fmoko%2Fwidgets-collection

also you can use current development version (from develop branch) - it publish on maven too:
https://bintray.com/icerockdev/moko-dev/moko-widgets
https://bintray.com/icerockdev/plugins-dev/moko-widgets-generator
and just set commit sha as version name (d4201af latest now)
but by using develop version you will not got migration notes and changelog. here already many changes - https://github.com/icerockdev/moko-widgets/compare/develop but it have many improvements https://github.com/icerockdev/moko-widgets/milestone/15?closed=1

@stevesoltys
Copy link
Contributor Author

Got it. I'm all set now. Thanks!

@Alex009 Alex009 modified the milestones: 0.1.0-dev-20, 0.1.0-dev-21 Aug 30, 2020
@Alex009 Alex009 modified the milestones: 0.1.0, 0.2.0 Jul 15, 2021
@Alex009 Alex009 removed this from the 0.2.0 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants