Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox: defaultQuery and autoFilter don't work well together #724

Open
wkeese opened this issue Nov 26, 2019 · 0 comments
Open

Combobox: defaultQuery and autoFilter don't work well together #724

wkeese opened this issue Nov 26, 2019 · 0 comments

Comments

@wkeese
Copy link
Member

wkeese commented Nov 26, 2019

If you create a Combobox with defaultQuery specified, the initial dropdown list will be filtered by defaultQuery.

However, once the user starts typing a search string, the dropdown list will be filtered by that search string.

It should be filtered by both the defaultQuery and the search string.

The code in question is in ComboboxImplementation#filter() and getQuery().
wkeese added a commit that referenced this issue Nov 27, 2019
@wkeese
Make sure that we set list.defaultQuery in addition to list.source.
f7da07b 
Refs #724 tangentially.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wkeese