Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwapView: make PageDown go to next page, PageUp go to previous page #580

Open
wkeese opened this issue Jun 29, 2015 · 0 comments
Open

SwapView: make PageDown go to next page, PageUp go to previous page #580

wkeese opened this issue Jun 29, 2015 · 0 comments

Comments

@wkeese
Copy link
Member

wkeese commented Jun 29, 2015

In SwapView, PageUp goes to the next child, and PageDown goes to the previous child.

Although this corresponds to what's written in SwapView.md, this is the opposite behavior than I expected. It's also opposite from the aria spec, which states:

  • Ctrl+PageUp - When focus is inside of a tab panel, pressing Ctrl+PageUp moves focus to the tab of the previous tab in the tab list and activates that tab. When focus is in the first tab panel in the tab list, pressing Ctrl+PageUp will move focus to the last tab in the tab list and activate that tab.
  • Ctrl+PageDown When focus is inside of a tab panel, pressing Ctrl+PageDown moves focus to the tab of the next tab in the tab list and activates that tab. When focus is in the last tab panel in the tab list, pressing Ctrl+PageUpwill move focus to the first tab in the tab list and activate that tab.

On a related note, as noted above, SwapView should presumably listen for Ctrl+PageUp and Ctrl+PageDown, not plain PageUp and PageDown, because plain PageUp and PageDown are for scrolling (assuming that the SwapView's child has enough content to cause a scrollbar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant