Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: blocklist of certain domains #7

Open
ddxv opened this issue Mar 2, 2024 · 6 comments
Open

Feature Request: blocklist of certain domains #7

ddxv opened this issue Mar 2, 2024 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ddxv
Copy link

ddxv commented Mar 2, 2024

FTTF significantly slows down when opening large files on localhost:

image

It would be good to have a block or ban list to prevent FTTF from running on localhost or others.

@iansinnott
Copy link
Owner

Thanks for the report. What type of page was that out of curiosity? Wondering what HTML would cause it to slow down like that.

A blacklist is a good idea though. I think this has been mentioned elsewhere. Also a way to purge things that have already been imported.

@iansinnott iansinnott added the enhancement New feature or request label Mar 3, 2024
@ddxv
Copy link
Author

ddxv commented Mar 3, 2024 via email

@iansinnott iansinnott added the bug Something isn't working label Apr 22, 2024
@iansinnott
Copy link
Owner

Ah yeah, it's probably a big amount of data which is an edge case the extension doesn't handle well. There's no special logic for something like "If this page is 12mb of binary data", so it's not surprising it's slow.

@iansinnott
Copy link
Owner

To do the blacklist we would need to also remove existing entries that matched. A simpler approach might be some kind of heuristic to stop indexing if the detected page content is unusually large.

@VVytai
Copy link

VVytai commented Jun 23, 2024

On some websites, readability lib can cause missing paragraphs in the saved text. It would be nice to also implement a user-defined "reader mode blacklist" to disable readability on those websites.

@iansinnott
Copy link
Owner

Blacklist is coming in next release. Not custom readability, at least not yet, but the ability to block certain URL patterns from getting indexed.

@iansinnott iansinnott mentioned this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants