From 655a05fb66a15b76fc34b00436e56c689b4a2c7b Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Tue, 25 May 2021 14:57:51 -0400
Subject: [PATCH 1/6] profile merging interface added

---
 biostar/forum/auth.py                         | 31 ++++++++-
 biostar/forum/forms.py                        | 45 +++++++++++++
 .../templates/accounts/merge_profile.html     | 64 +++++++++++++++++++
 .../forum/templates/banners/menu-header.html  | 13 +++-
 biostar/forum/tests/test_moderate.py          | 15 ++++-
 biostar/forum/tests/test_navigation.py        |  4 +-
 biostar/forum/urls.py                         |  1 +
 biostar/forum/views.py                        | 22 ++++++-
 biostar/server/test_settings.py               |  2 +-
 biostar/utils/decorators.py                   | 14 ++++
 10 files changed, 202 insertions(+), 9 deletions(-)
 create mode 100644 biostar/forum/templates/accounts/merge_profile.html

diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index f4f779386..a16e13d72 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -21,7 +21,7 @@
 from biostar.utils.helpers import get_ip
 from . import util, awards
 from .const import *
-from .models import Post, Vote, Subscription, Badge, delete_post_cache, Log
+from .models import Post, Vote, Subscription, Badge, delete_post_cache, Log, Award
 
 User = get_user_model()
 
@@ -228,6 +228,35 @@ def create_post(author, title, content, request, root=None, parent=None, ptype=P
     return post
 
 
+def merge_profiles(main, alias):
+    """
+    Merge alias profile into main
+    """
+
+    # Transfer posts
+    Post.objects.filter(author=alias).update(author=main)
+
+    Post.objects.filter(lastedit_user=alias).update(lastedit_user=main)
+
+    # Transfer votes
+    Vote.objects.filter(author=alias).update(author=main)
+
+    # Transfer subscriptions
+    Subscription.objects.filter(user=alias).update(user=main)
+
+    # Transfer awards
+    Award.objects.filter(user=alias).update(user=main)
+
+    # Transfer messages
+    Message.objects.filter(sender=alias).update(sender=main)
+    Message.objects.filter(recipient=alias).update(recipient=main)
+
+    # Remove alias profile.
+    #Profile.objects.filter(user=alias).update(state=Profile.SUSPENDED)
+
+    return
+
+
 def create_subscription(post, user, sub_type=None, update=False):
     """
     Creates subscription to a post. Returns a list of subscriptions.
diff --git a/biostar/forum/forms.py b/biostar/forum/forms.py
index 1c37c6918..760b5f501 100644
--- a/biostar/forum/forms.py
+++ b/biostar/forum/forms.py
@@ -206,3 +206,48 @@ def clean(self):
         if self.user.is_anonymous:
             raise forms.ValidationError("You need to be logged in.")
         return cleaned_data
+
+
+class MergeProfiles(forms.Form):
+
+    main = forms.CharField(label='Main user email', max_length=100, required=True)
+    alias = forms.CharField(label='Alias email to merge to main', max_length=100, required=True)
+
+    def clean_main(self):
+        cleaned_data = super(MergeProfiles, self).clean()
+        main = cleaned_data['main']
+        if not User.objects.filter(email=main).first():
+            raise forms.ValidationError(f'{main} email does not exist.')
+
+        return main
+
+    def clean_alias(self):
+        cleaned_data = super(MergeProfiles, self).clean()
+        alias = cleaned_data['alias']
+        if not User.objects.filter(email=alias).first():
+            raise forms.ValidationError(f'{alias} email does not exist.')
+
+        return alias
+
+    def clean(self):
+        cleaned_data = super(MergeProfiles, self).clean()
+        alias = cleaned_data['alias']
+        main = cleaned_data['main']
+
+        if main == alias:
+            raise forms.ValidationError('Main and alias profiles are the same.')
+
+        return cleaned_data
+
+    def save(self):
+
+        alias = self.cleaned_data['alias']
+        main = self.cleaned_data['main']
+
+        main = User.objects.filter(email=main).first()
+        alias = User.objects.filter(email=alias).first()
+
+        # Merge the two accounts.
+        auth.merge_profiles(main=main, alias=alias)
+
+        return main
\ No newline at end of file
diff --git a/biostar/forum/templates/accounts/merge_profile.html b/biostar/forum/templates/accounts/merge_profile.html
new file mode 100644
index 000000000..75080a646
--- /dev/null
+++ b/biostar/forum/templates/accounts/merge_profile.html
@@ -0,0 +1,64 @@
+{% extends "forum_base.html" %}
+{% load forum_tags %}
+{% load socialaccount %}
+{% block headtitle %}Login{% endblock %}
+
+{% block content %}
+  <form class="ui form" method="post" action="{% url 'merge_profile' %}">
+
+        <div class="ui segment inputcolor socialbox">
+
+            <div class="ui center aligned header">
+                Merge Profiles
+            </div>
+
+            {% csrf_token %}
+
+            {{ form.errors }}
+
+            <div class="fields">
+
+                    <div class="field">
+
+                        <label><i class="user outline icon"></i> Alias Profile</label>
+                        {{ form.alias }}
+                        <div class="muted">
+                            Email to the alias profile
+                        </div>
+
+                    </div>
+                <div class="field" style="margin: auto">
+                    <i class="angle double right icon"></i>
+                </div>
+
+                    <div class="field">
+
+                        <label><i class="user icon"></i> Main Profile</label>
+                        {{ form.main }}
+                        <div class="muted">
+                            Email to main profile
+                        </div>
+
+                    </div>
+
+
+                </div>
+
+            <div class="field">
+                <button class="ui primary button" type="submit">
+                    <i class="user plus icon"></i>Merge
+                </button>
+
+                <a class="ui right floated button" href="#" onclick="window.history.back()">
+                    <i class="chevron left icon"></i>Back
+                </a>
+            </div>
+
+        </div>
+
+
+    </form>
+
+
+
+{% endblock %}
diff --git a/biostar/forum/templates/banners/menu-header.html b/biostar/forum/templates/banners/menu-header.html
index 2e55e967d..7b3af5749 100644
--- a/biostar/forum/templates/banners/menu-header.html
+++ b/biostar/forum/templates/banners/menu-header.html
@@ -33,10 +33,17 @@
         <i class="info circle icon"></i>About
     </a>
 
-        <a class="item  {% activate tab "faq" %}" href="/info/faq/">
+    <a class="item  {% activate tab "faq" %}" href="/info/faq/">
         <i class="info recycle icon"></i>FAQ
     </a>
 
+    {% if request.user.is_staff or request.user.is_superuser %}
+        <a class="item  {% activate tab "merge" %}" href="{% url 'merge_profile' %}">
+            <i class="user plus icon"></i>Merge
+        </a>
+
+    {% endif %}
+
 </div>
 
 <div class="ui labeled icon top attached evenly divided menu" id="menu-header" user-id="{{ request.user.id }}">
@@ -53,12 +60,12 @@
     </a>
 
     <a class="item {% activate tab "planet" %} " href="{% url 'blog_list' %}">
-        <i class="rss icon"></i> Planet  {% count_badge counts.planet_count %}
+        <i class="rss icon"></i> Planet {% count_badge counts.planet_count %}
     </a>
 
     {% if request.user.profile.is_moderator %}
         <a class="item {% activate tab 'spam' %} " href="{% url 'post_topic' 'spam' %}">
-            <i class="bug icon"></i> Spam  {% count_badge counts.spam_count %}
+            <i class="bug icon"></i> Spam {% count_badge counts.spam_count %}
         </a>
         <a class="item {% activate tab 'activity' %} " href="{% url 'view_logs' %}">
             <i class="chess queen icon"></i> Mods {% count_badge counts.mod_count %}
diff --git a/biostar/forum/tests/test_moderate.py b/biostar/forum/tests/test_moderate.py
index dfb629f65..56b0c35a0 100644
--- a/biostar/forum/tests/test_moderate.py
+++ b/biostar/forum/tests/test_moderate.py
@@ -19,7 +19,8 @@ def setUp(self):
         logger.setLevel(logging.WARNING)
         self.owner = User.objects.create(username=f"tested{get_uuid(10)}", email="tested@tested.com",
                                          password="tested", is_superuser=True, is_staff=True)
-
+        self.user2 = User.objects.create(username=f"test{get_uuid(10)}", email="test@test.com",
+                                         password="test", is_superuser=True, is_staff=True)
         # Create an existing tested post
         self.post = models.Post.objects.create(title="Test", author=self.owner, content="Test", type=models.Post.QUESTION, uid='foo')
         self.uid = 'foo'
@@ -78,6 +79,18 @@ def test_comment_moderation(self):
 
         self.moderate(choices=choices, post=comment, extra={'pid': self.post.uid})
 
+    def test_merge_profile(self):
+        "Test merging two profiles"
+
+        # Create fake request
+        data = {'main': self.owner.email, 'alias': self.user2.email}
+
+        request = fake_request(url=reverse('merge_profile'), data=data, user=self.owner)
+        response = views.merge_profile(request=request)
+
+        self.process_response(response)
+
+        pass
 
     def process_response(self, response):
         "Check the response on POST request is redirected"
diff --git a/biostar/forum/tests/test_navigation.py b/biostar/forum/tests/test_navigation.py
index bcdf6434e..e785b7b4c 100644
--- a/biostar/forum/tests/test_navigation.py
+++ b/biostar/forum/tests/test_navigation.py
@@ -22,7 +22,7 @@ class ForumNavigation(TestCase):
     def setUp(self):
         logger.setLevel(logging.WARNING)
 
-        self.owner = User.objects.create(username=f"tested{get_uuid(10)}", email="tested@tested.com")
+        self.owner = User.objects.create(username=f"tested{get_uuid(10)}", email="tested@tested.com", is_staff=True)
         self.owner.set_password("tested")
         self.badge = Badge.objects.first()
         # Create a tested post
@@ -60,7 +60,7 @@ def test_public_pages(self):
             reverse("myvotes"),
             reverse('api_traffic'),
             reverse('latest_feed'),
-            reverse('latest_feed'),
+            reverse('merge_profile'),
             reverse('post_tags', kwargs=dict(tag='tag1')),
             reverse('tag_feed', kwargs=dict(text='tag1')),
             reverse('post_feed', kwargs=dict(text=self.post.uid)),
diff --git a/biostar/forum/urls.py b/biostar/forum/urls.py
index 4373493e5..4b32165eb 100644
--- a/biostar/forum/urls.py
+++ b/biostar/forum/urls.py
@@ -88,6 +88,7 @@
     path(r'feeds/post/<str:text>/', feed.PostFeed(), name='post_feed' ),
     path(r'feeds/type/<str:text>/', feed.PostTypeFeed(), name='post_type'),
     #path(r'^feeds/planet/$', feed.PlanetFeed(), name='planet-feed'),
+    path(r'merge/', views.merge_profile, name="merge_profile"),
 
 ]
 
diff --git a/biostar/forum/views.py b/biostar/forum/views.py
index 1dc394374..1ca1572b8 100644
--- a/biostar/forum/views.py
+++ b/biostar/forum/views.py
@@ -19,7 +19,7 @@
 from biostar.forum import forms, auth, tasks, util, search, models, moderate
 from biostar.forum.const import *
 from biostar.forum.models import Post, Vote, Badge, Subscription, Log
-from biostar.utils.decorators import is_moderator, check_params, reset_count
+from biostar.utils.decorators import is_moderator, check_params, reset_count, is_staff
 
 User = get_user_model()
 
@@ -627,6 +627,26 @@ def view_logs(request):
     return render(request, "view_logs.html", context=context)
 
 
+@is_staff
+def merge_profile(request):
+    """
+    Merge two profiles into one.
+    """
+
+    form = forms.MergeProfiles()
+
+    if request.method == 'POST':
+        form = forms.MergeProfiles(data=request.POST)
+
+        if form.is_valid():
+            merged = form.save()
+            messages.success(request, "Merged profiles")
+            return redirect(reverse('user_profile', kwargs=dict(uid=merged.profile.uid)))
+
+    context = dict(form=form)
+    return render(request, "accounts/merge_profile.html", context=context)
+
+
 def error(request):
     """
     Checking error propagation and logging
diff --git a/biostar/server/test_settings.py b/biostar/server/test_settings.py
index d5badd3e6..bd9adb4c5 100644
--- a/biostar/server/test_settings.py
+++ b/biostar/server/test_settings.py
@@ -2,7 +2,7 @@
 
 # Do not multi-thread tests.
 
-TASK_RUNNER = "disable"
+TASK_RUNNER = "block"
 
 INIT_PLANET = False
 
diff --git a/biostar/utils/decorators.py b/biostar/utils/decorators.py
index 480529240..b85df9199 100644
--- a/biostar/utils/decorators.py
+++ b/biostar/utils/decorators.py
@@ -23,6 +23,20 @@ def inner(request, **kwargs):
     return inner
 
 
+def is_staff(f):
+    """
+    Only run functions with the
+    """
+    def inner(request, **kwargs):
+        user = request.user
+        if user.is_authenticated and (user.is_staff or user.is_superuser):
+            return f(request, **kwargs)
+        messages.warning(request, "You need to be a staff member to perform this action.")
+        return redirect('/')
+
+    return inner
+
+
 def reset_count(key):
     """
     Set value of given key in settings.SESSION_COUNT_KEY to 0.

From 8ca4481c40f4c7630ed735569367ae18057e6a84 Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Tue, 25 May 2021 20:17:18 -0400
Subject: [PATCH 2/6] add inplace.js to compress block

---
 biostar/forum/auth.py                              | 8 ++++----
 biostar/forum/templates/accounts/edit_profile.html | 1 -
 biostar/forum/templates/base_view.html             | 1 -
 biostar/forum/templates/forum_base.html            | 1 +
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index a16e13d72..c6da3a95a 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -213,13 +213,13 @@ def create_post(author, title, content, request, root=None, parent=None, ptype=P
     post = Post.objects.filter(content=content, author=author).order_by('-creation_date').first()
 
     # How many seconds since the last post should we disallow duplicates.
-    since = 60
+    time_frame = 60
     if post:
-        # Check to see if this post was made within the last minute.
+        # Check to see if this post was made within given timeframe
         delta_secs = (util.now() - post.creation_date).seconds
-        if delta_secs < since:
+        if delta_secs < time_frame:
             messages.warning(request, "Post with this content was created recently.")
-            return post.root
+            return post
 
     post = Post.objects.create(title=title, content=content, root=root, parent=parent,
                                type=ptype, tag_val=tag_val, author=author)
diff --git a/biostar/forum/templates/accounts/edit_profile.html b/biostar/forum/templates/accounts/edit_profile.html
index 2675a31d0..5c1f41b3d 100644
--- a/biostar/forum/templates/accounts/edit_profile.html
+++ b/biostar/forum/templates/accounts/edit_profile.html
@@ -15,7 +15,6 @@
 {% endblock %}
 
 {% block js %}
-
     <script src="{% static 'semantic.min.js' %}"></script>
     <script src="{% static 'prism.js' %}"></script>
     <script src="{% static 'setup.js' %}{% randparam %}"></script>
diff --git a/biostar/forum/templates/base_view.html b/biostar/forum/templates/base_view.html
index b2163fda1..04c974bd0 100644
--- a/biostar/forum/templates/base_view.html
+++ b/biostar/forum/templates/base_view.html
@@ -35,5 +35,4 @@
 {% block jsfile %}
     <script src="{% static 'setup.js' %}{% randparam %}"></script>
     <script src="{% static 'effects.js' %}{% randparam %}"></script>
-    <script src="{% static 'inplace.js' %}{% randparam %}"></script>
 {% endblock %}
\ No newline at end of file
diff --git a/biostar/forum/templates/forum_base.html b/biostar/forum/templates/forum_base.html
index 7c8211962..cf770366b 100644
--- a/biostar/forum/templates/forum_base.html
+++ b/biostar/forum/templates/forum_base.html
@@ -56,6 +56,7 @@
     {% compress js %}
         <script src="{% static 'semantic.min.js' %}"></script>
         <script src="{% static 'forum.js' %}{% randparam %}"></script>
+        <script src="{% static 'inplace.js' %}{% randparam %}"></script>
         {% block jsfile %}
         {% endblock %}
 

From 92d472a091b82e0071e045ac2fc4efea5a0506c6 Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Wed, 26 May 2021 09:48:44 -0400
Subject: [PATCH 3/6] update

---
 biostar/forum/auth.py | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index c6da3a95a..037cf38c8 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -235,24 +235,17 @@ def merge_profiles(main, alias):
 
     # Transfer posts
     Post.objects.filter(author=alias).update(author=main)
-
     Post.objects.filter(lastedit_user=alias).update(lastedit_user=main)
 
-    # Transfer votes
-    Vote.objects.filter(author=alias).update(author=main)
-
-    # Transfer subscriptions
-    Subscription.objects.filter(user=alias).update(user=main)
-
-    # Transfer awards
-    Award.objects.filter(user=alias).update(user=main)
-
     # Transfer messages
     Message.objects.filter(sender=alias).update(sender=main)
     Message.objects.filter(recipient=alias).update(recipient=main)
 
-    # Remove alias profile.
+    # change names to delete( alias) and keep ( main)
+    #TODO: sanity check; alias can only be reg low-score user,
+    # alias can not be newer then main
     #Profile.objects.filter(user=alias).update(state=Profile.SUSPENDED)
+    alias.delete()
 
     return
 

From d5b738d7114666d1ec5631ea39b05a7d01ef7afa Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Fri, 28 May 2021 08:32:29 -0400
Subject: [PATCH 4/6] update

---
 biostar/accounts/models.py                    |  6 ++++
 biostar/forum/auth.py                         |  8 +++---
 biostar/forum/forms.py                        | 28 +++++++++----------
 .../templates/accounts/merge_profile.html     |  6 ++--
 .../forum/templates/accounts/profile_tab.html |  2 +-
 .../forum/templates/banners/menu-header.html  |  6 ----
 biostar/forum/views.py                        |  5 ++--
 7 files changed, 31 insertions(+), 30 deletions(-)

diff --git a/biostar/accounts/models.py b/biostar/accounts/models.py
index 77b955dc9..9d406d58c 100644
--- a/biostar/accounts/models.py
+++ b/biostar/accounts/models.py
@@ -313,6 +313,12 @@ def low_rep(self):
         """
         return self.score <= settings.LOW_REP_THRESHOLD and not self.is_moderator
 
+    @property
+    def high_rep(self):
+        """
+        """
+
+        return not self.low_rep
 
 class UserLog(models.Model):
     DEFAULT, ACTION = 1, 2
diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index 037cf38c8..66b81d5e4 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -241,10 +241,10 @@ def merge_profiles(main, alias):
     Message.objects.filter(sender=alias).update(sender=main)
     Message.objects.filter(recipient=alias).update(recipient=main)
 
-    # change names to delete( alias) and keep ( main)
-    #TODO: sanity check; alias can only be reg low-score user,
-    # alias can not be newer then main
-    #Profile.objects.filter(user=alias).update(state=Profile.SUSPENDED)
+    # Do not delete alias is older than main.
+    if alias.profile.is_moderator or alias.profile.high_rep or (alias.profile.date_joined < main.profile.date_joined):
+        return
+
     alias.delete()
 
     return
diff --git a/biostar/forum/forms.py b/biostar/forum/forms.py
index 760b5f501..fde043c78 100644
--- a/biostar/forum/forms.py
+++ b/biostar/forum/forms.py
@@ -213,26 +213,26 @@ class MergeProfiles(forms.Form):
     main = forms.CharField(label='Main user email', max_length=100, required=True)
     alias = forms.CharField(label='Alias email to merge to main', max_length=100, required=True)
 
-    def clean_main(self):
+    def __init__(self, user=None, *args, **kwargs):
+        self.user = user
+        super().__init__(*args, **kwargs)
+
+    def clean(self):
         cleaned_data = super(MergeProfiles, self).clean()
+        alias = cleaned_data['alias']
         main = cleaned_data['main']
-        if not User.objects.filter(email=main).first():
-            raise forms.ValidationError(f'{main} email does not exist.')
 
-        return main
+        to_delete = User.objects.filter(email=alias).first()
+        merge_to = User.objects.filter(email=main).first()
 
-    def clean_alias(self):
-        cleaned_data = super(MergeProfiles, self).clean()
-        alias = cleaned_data['alias']
-        if not User.objects.filter(email=alias).first():
-            raise forms.ValidationError(f'{alias} email does not exist.')
+        if self.user and not (self.user.is_staff or self.user.is_superuser):
+            raise forms.ValidationError(f'Only staff member can perform this action.')
 
-        return alias
+        if not to_delete:
+            raise forms.ValidationError(f'{alias} email does not exist.')
 
-    def clean(self):
-        cleaned_data = super(MergeProfiles, self).clean()
-        alias = cleaned_data['alias']
-        main = cleaned_data['main']
+        if not merge_to:
+            raise forms.ValidationError(f'{main} email does not exist.')
 
         if main == alias:
             raise forms.ValidationError('Main and alias profiles are the same.')
diff --git a/biostar/forum/templates/accounts/merge_profile.html b/biostar/forum/templates/accounts/merge_profile.html
index 75080a646..e6a51ec72 100644
--- a/biostar/forum/templates/accounts/merge_profile.html
+++ b/biostar/forum/templates/accounts/merge_profile.html
@@ -20,10 +20,10 @@
 
                     <div class="field">
 
-                        <label><i class="user outline icon"></i> Alias Profile</label>
+                        <label><i class="trash can icon"></i> Delete Profile</label>
                         {{ form.alias }}
                         <div class="muted">
-                            Email to the alias profile
+                            Email to delete
                         </div>
 
                     </div>
@@ -36,7 +36,7 @@
                         <label><i class="user icon"></i> Main Profile</label>
                         {{ form.main }}
                         <div class="muted">
-                            Email to main profile
+                            Email to merge into
                         </div>
 
                     </div>
diff --git a/biostar/forum/templates/accounts/profile_tab.html b/biostar/forum/templates/accounts/profile_tab.html
index 6e2f1a239..287b40505 100644
--- a/biostar/forum/templates/accounts/profile_tab.html
+++ b/biostar/forum/templates/accounts/profile_tab.html
@@ -29,7 +29,7 @@
             {% if request.user.is_superuser or request.user.is_staff %}
                <div class="ui mini button blue disable-emails">
                     <i class="mail icon"></i>
-                    Disable Messages
+                    Silence
                 </div>
             {% endif %}
 
diff --git a/biostar/forum/templates/banners/menu-header.html b/biostar/forum/templates/banners/menu-header.html
index 7b3af5749..592ec42fb 100644
--- a/biostar/forum/templates/banners/menu-header.html
+++ b/biostar/forum/templates/banners/menu-header.html
@@ -37,12 +37,6 @@
         <i class="info recycle icon"></i>FAQ
     </a>
 
-    {% if request.user.is_staff or request.user.is_superuser %}
-        <a class="item  {% activate tab "merge" %}" href="{% url 'merge_profile' %}">
-            <i class="user plus icon"></i>Merge
-        </a>
-
-    {% endif %}
 
 </div>
 
diff --git a/biostar/forum/views.py b/biostar/forum/views.py
index 1ca1572b8..b9a913746 100644
--- a/biostar/forum/views.py
+++ b/biostar/forum/views.py
@@ -633,10 +633,11 @@ def merge_profile(request):
     Merge two profiles into one.
     """
 
-    form = forms.MergeProfiles()
+    user = request.user
+    form = forms.MergeProfiles(user=user)
 
     if request.method == 'POST':
-        form = forms.MergeProfiles(data=request.POST)
+        form = forms.MergeProfiles(user=user, data=request.POST)
 
         if form.is_valid():
             merged = form.save()

From 67112867871b76d4acea78e2bd897ed7d5bf532b Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Fri, 28 May 2021 08:49:38 -0400
Subject: [PATCH 5/6] update

---
 biostar/forum/auth.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index 66b81d5e4..10283ca0a 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -241,8 +241,10 @@ def merge_profiles(main, alias):
     Message.objects.filter(sender=alias).update(sender=main)
     Message.objects.filter(recipient=alias).update(recipient=main)
 
-    # Do not delete alias is older than main.
-    if alias.profile.is_moderator or alias.profile.high_rep or (alias.profile.date_joined < main.profile.date_joined):
+    # Do not delete 'alias' if it is older than main profile.
+    older = (alias.profile.date_joined < main.profile.date_joined)
+
+    if alias.profile.is_moderator or alias.profile.high_rep or older:
         return
 
     alias.delete()

From 2ca7f04d7df3c2b83c8ba357680baaf30b1d74a3 Mon Sep 17 00:00:00 2001
From: Natay Aberra <natay.aberra@gmail.com>
Date: Fri, 28 May 2021 08:55:10 -0400
Subject: [PATCH 6/6] update

---
 biostar/forum/auth.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/biostar/forum/auth.py b/biostar/forum/auth.py
index 10283ca0a..89cac4acb 100644
--- a/biostar/forum/auth.py
+++ b/biostar/forum/auth.py
@@ -241,7 +241,7 @@ def merge_profiles(main, alias):
     Message.objects.filter(sender=alias).update(sender=main)
     Message.objects.filter(recipient=alias).update(recipient=main)
 
-    # Do not delete 'alias' if it is older than main profile.
+    # Do not delete older accounts.
     older = (alias.profile.date_joined < main.profile.date_joined)
 
     if alias.profile.is_moderator or alias.profile.high_rep or older: