TablePaginator only shows ellipses when needed
#2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-show-ellipses-only-when-needed
r100-stack
changed the base branch from
main
to
r/table-paginator-arrow-keys-bug
2 tasks
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
approved these changes
Oct 15, 2024
smmr-dn
approved these changes
Oct 15, 2024
Co-authored-by: Mayank <[email protected]>
r100-stack
deleted the
r/table-paginator-show-ellipses-only-when-needed
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Shows ellipses only when there is a gap of one or more page in between the extremities and the middle pages.
Testing
"…"between 1 & 2"…"between 100 & 101Docs
Added changeset
After PR TODOs:
&&with ternary expressions. Also update the style guide and try adding a lint rule. (#2303 (comment)).