Add check for undefined header in Column resizer

[LostABike]

Changes

When resizing the last column that is column manager in expand mode, the table crashes with error "cannot read properties of undefined" which seem to occur from using getHeaderWidth function. So I added a check within that function to see whether if header is undefined and return 0.

Closes #1004

Testing

• Tested column manager table in Storybook with extra prop isResizable=true and columnResizerMode='expand'

Docs

• Added changeset

[elephantcatdog]

So this doesn't show the error anymore, but it doesn't allow me to actually resize the column in the example the user sent in. Does it work for you in the storybook story?

[LostABike]

@elephantcatdog the storybook story works.

So this doesn't show the error anymore, but it doesn't allow me to actually resize the column in the example the user sent in. Does it work for you in the storybook story?

The storybook story works-ish..? I'm not too confident about the expected behavior though:

For user's example, I think it works too but because it makes the table width increase which cause the horizontal scroll appear while things look unchanged..?

I was thinking that we disable resizing for the the selection/first column, should we do the same for column manager column? That would keep the table width the same too. But I'm not sure what the expected behavior should be.

[elephantcatdog]

@LostABike Oooh, I see now. I was trying to make the column manager column bigger, but I actually don't see a reason for that to be bigger IMO. In that case, I tested it and this looks good to me.

Except that there's a test failing, but it looks like it's a CSS visual test on tiles, so that's unrelated. I'm going to merge main in and rerun them to see if that fixes the test.

Update: I ran the tests locally and it passed... so 🤷‍♂️

[gretanausedaite]

It fixes the error but now I can make columns smaller than table.

[LostABike]

It fixes the error but now I can make columns smaller than table.

I can't seem to reproduce this 😮 I used the user's example to run locally in vite, which I believe was what you did as well. Could you elaborate on how you were able to reproduce that bug?

[gretanausedaite]

Could you elaborate on how you were able to reproduce that bug?

Screen.Recording.2023-04-04.at.15.20.01.mov

I think it's something with how we calculate min width of the column based on table width.

[gretanausedaite]

I think we can merge this as a hotfix for crashing. Table changing size is better than app not working.
We just need to add a new issue for resizing bugs.

@LostABike @mayank99 What do you think?

[LostABike]

I think we can merge this as a hotfix for crashing. Table changing size is better that app not working. We just need to add a new issue for resizing bugs.

@LostABike @mayank99 What do you think?

Yea I think that would be optimal...I could not figure the following bug out x_x

[mayank99]

Sounds good to me. Lets merge this PR and reopen the issue.