Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Review documentation of each component #961

Open
58 of 68 tasks
FlyersPh9 opened this issue Jan 6, 2023 · 4 comments
Open
58 of 68 tasks

Website: Review documentation of each component #961

FlyersPh9 opened this issue Jan 6, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Jan 6, 2023

In prep for the new documentation site going live, we need to review the content that we have so far. Here is what we need to do:

  • Review the text that was copied over from the internal documentation site.
    • Only document what a component is capable of doing now, remove any documentation on features that we do not yet support.
    • Some documentation mentions restrictions that iTwinUI does not enforce. Reword this from a restriction to a suggestion. Example: "A button can only have 20 characters" 👉 "We suggest a button only have 20 characters"
    • If a component page mentions another component, the first instance of that other component being mentioned should link to that page. Example: see tags link on line 20 of badges PR.
    • Remove any mention of visual composition as the design system handles this. Example of text that could be removed: "A button is 36px tall and has 4px rounded corners"
    • Consistent H2 sections. As of right now, I think we should aim for each page to have Appearance, Usage, & Props.
  • Introduce more demos.
    • Each page should have a generic top of page demo.
    • Each section under Appearance Variants should have a demo.
    • Each section should be ordered:
      1. Title
      2. Paragraph(s)
      3. Demo
      4. Paragraph
      5. Demo
      6. etc
    • Demos should be named like exampleCodeCTA: Button.CTA.tsx, do not use generic names like exampleCode1: Button.1.tsx.

To do:

Some of the components which don't have more than one PR needs review.

@FlyersPh9 FlyersPh9 added the documentation Improvements or additions to documentation label Jan 6, 2023
@FlyersPh9 FlyersPh9 self-assigned this Jan 6, 2023
@siddhantrawal siddhantrawal self-assigned this Oct 23, 2023
@FlyersPh9
Copy link
Collaborator Author

Does it make sense to document MiddleTextTruncation?

@FlyersPh9
Copy link
Collaborator Author

Add divider component.

@FlyersPh9
Copy link
Collaborator Author

From our iTwinUI community meeting:

document noreferrer for anchors

@veekeys

@veekeys
Copy link
Member

veekeys commented Feb 20, 2024

From our iTwinUI community meeting:

document noreferrer for anchors

@veekeys

https://cheatsheetseries.owasp.org/cheatsheets/HTML5_Security_Cheat_Sheet.html#tabnabbing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

7 participants