css class name and hierarchy changed for IconButtons #1182
-
User was using @itwin/itwinui-react: 1.30.0 previously and updated to @itwin/itwinui-react: 2.7.0 recently. They have designed their buttons based on the class names in the old version and now when they update to newer version they see the classnames and hierarchies changed, due to which apperance of their buttons have changed. For ex, Below is the change in IconButton
css was like this:
itwinui-react: 2.7.0
IconButton is just an example, they have same issues in other UI controls as well. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
we have documented all dom structure changes here: https://github.com/iTwin/iTwinUI/wiki/iTwinUI-v1-migration-guide But in general, the user should not rely on our internal classes. Instead you should only target custom classes so that you are shielded from any breaking changes we make to our classes. In the next major version, we are planning to rename every single class and make it an implementation detail. as a side note, your markup looks invalid. There should be no |
Beta Was this translation helpful? Give feedback.
-
Thanks @mayank99 I will let user know about this. will comeback if they have any questions. |
Beta Was this translation helpful? Give feedback.
we have documented all dom structure changes here: https://github.com/iTwin/iTwinUI/wiki/iTwinUI-v1-migration-guide
But in general, the user should not rely on our internal classes. Instead you should only target custom classes so that you are shielded from any breaking changes we make to our classes. In the next major version, we are planning to rename every single class and make it an implementation detail.
as a side note, your markup looks invalid. There should be no
<label>
element inside a<button>
.