Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local IP selection in Config Flow #576

Closed
1 task done
iMicknl opened this issue Sep 22, 2021 · 12 comments
Closed
1 task done

Add support for local IP selection in Config Flow #576

iMicknl opened this issue Sep 22, 2021 · 12 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@iMicknl
Copy link
Owner

iMicknl commented Sep 22, 2021

Did you read the instructions?

The request

@dmaasland did a great job researching how to 'jailbreak' his Somfy Connexoon box. You can read more about this on the Home Assistant Community Forum.

Currently he is using a modified version of this integration, but it would be good to add support for local IP address selection to the HA Config Flow. I don't think many users will use this, but it is good to have it in.

dmaasland/python-tahoma-api@2d66743
dmaasland@3962777

Which gateway / hub do you use?

n/a

Device model (optional)

No response

Device type (optional)

No response

Additional information

Needs an updated pyhoma version.

@iMicknl iMicknl added the enhancement New feature or request label Sep 22, 2021
Repository owner deleted a comment from github-actions bot Oct 23, 2021
@github-actions
Copy link

'There hasn't been any activity on this issue recently. Is this issue still present?
Please make sure to update to the latest Home Assistant version and version of this integration to see if that solves the issue. Let us know if that works for you by adding a comment 👍.
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.'

@jozg
Copy link

jozg commented Nov 29, 2021

I'm still interested in this feature, so if you please be so kind to implement this feature. thank you.
Regards,

@iMicknl
Copy link
Owner Author

iMicknl commented Dec 2, 2021

@jozg did you jailbreak / root your hub?

@jozg
Copy link

jozg commented Dec 3, 2021

Hello IMicnl, not yet, the day the feature is enabled i'm going to root my hub according the manual of Donny. It makes no sense for me to allready root it, and not being able to control it. thank you for your great work, and thanks to Donny for making the root enable. regards.

@iMicknl
Copy link
Owner Author

iMicknl commented Dec 3, 2021

@jozg Donny already has a custom version of this integration where he made the required changes, thus this shouldn't hold you back.

@jozg
Copy link

jozg commented Dec 3, 2021

ok, i asked him about that, but he mentioned to wait for this final integration, and pointed me to this topic link.
Where can i find the custom version? regards

@tetienne
Copy link
Collaborator

tetienne commented Dec 3, 2021

IMO, we should not expose this local entrypoint in the component it will confuse a lot of user and it’s not an "official" stuff. But, hoppefully we can integrate it in our client API.

@iMicknl
Copy link
Owner Author

iMicknl commented Dec 3, 2021

IMO, we should not expose this local entrypoint in the component it will confuse a lot of user and it’s not an "official" stuff. But, hoppefully we can integrate it in our client API.

I am also still in doubt for this one, we can also just keep it in the custom integration (when we move to core). But having a hub named 'Local' which will open a new dialog where users can add their IP would be sufficient for me as well. We can add more information in that new dialog, about that this is only for advanced users that rooted their bridge.

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

'There hasn't been any activity on this issue recently. Is this issue still present?
Please make sure to update to the latest Home Assistant version and version of this integration to see if that solves the issue. Let us know if that works for you by adding a comment 👍.
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.'

@jozg
Copy link

jozg commented Jan 3, 2022

Issue still not resolved completly

Repository owner deleted a comment from github-actions bot Feb 4, 2022
@rjlee
Copy link

rjlee commented Feb 20, 2022

Would having someone with a local api enabled hub help with testing ? I'd be happy to enable mine if that would help, just let me know.

@iMicknl
Copy link
Owner Author

iMicknl commented Feb 20, 2022

@rjlee that would help eventually, however didn't prioritize the work yet. See #697 for our roadmap.

Repository owner deleted a comment from github-actions bot Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

4 participants