refactor: disable cache by default

Author: hyrious

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- **refactor**: Disable `--cache` by default, it might be too aggressive.
+
 ## 0.10.10
 
 - **feat**: Add `--cwd` to change the working directory, it also affects the cache file logic.

src/build.ts

@@ -64,6 +64,13 @@ export interface CacheOptions {
   shims?: boolean;
 }
 
+function normalize(path: string) {
+  if (path.startsWith("./")) {
+    path = path.slice(2);
+  }
+  return path.replace(/[\/\\]/g, "+");
+}
+
 export async function build(
   entry: string,
   options: BuildOptions & { format: Format },
@@ -84,7 +91,8 @@ export async function build(
     sourcemap: true,
     sourcesContent: false,
     treeShaking: true,
-    outfile: join(tmpdir, entry.replace(/[\/\\]/g, "+") + extname[options.format]),
+    outfile: join(tmpdir, normalize(entry) + extname[options.format]),
+    metafile: cacheOptions?.cache,
     ...options,
   };
   if (cacheOptions?.cache && mtime(options.outfile!) > mtime(entry)) {

src/commands/default.ts

@@ -1,8 +1,5 @@
 import { ChildProcess, spawn, spawnSync } from "child_process";
 import { BuildFailure, BuildOptions } from "esbuild";
-import { readFile } from "fs/promises";
-import { dirname } from "path";
-import { pathToFileURL } from "url";
 import { EsbuildDevFlags, EsbuildDevOptions, EsbuildFlags, parse } from "../args.js";
 import { Format, build, delay, loadPlugins, loaderPath } from "../index.js";
 import { resolveMangleCache } from "./utils";
@@ -24,15 +21,12 @@ export async function defaultCommand(entry: string, argsBeforeEntry: string[], a
 
   const argsToEntry = [..._2, ...argsAfterEntry];
 
-  const devOptions = { shims: true, cache: true, cwd: process.cwd(), ...devOptionsRaw } as EsbuildDevOptions;
+  const devOptions = { shims: true, cwd: process.cwd(), ...devOptionsRaw } as EsbuildDevOptions;
   const buildOptions = buildOptionsRaw as BuildOptions & { format: Format };
   if (devOptions.import) devOptions.loader = true;
   if (devOptions.loader && (devOptions.cjs || devOptions.plugin || devOptions.watch || devOptions.include)) {
     throw new Error(`--cjs, --plugin, --watch and --include are not supported with --loader`);
   }
-  if (devOptions.loader || devOptions.plugin || devOptions.watch) {
-    devOptions.cache = false;
-  }
 
   buildOptions.format = devOptions.cjs ? "cjs" : "esm";
   resolveMangleCache(buildOptions);

src/help.txt

@@ -18,14 +18,15 @@ Options:
                         can only be accessed in ESM. This option cannot be used
                         with `--import`.
 
+  --cwd=...             Set the current working directory, it also affects the
+                        logic to find the temp directory.
+
   --shims               Replace `import.meta.url` and `__dirname` with absolute
                         path in .[tj]s files. This is enabled by default.
                         You can pass `--shims=false` to disable it.
 
   --cache               Skip build if the output file is newer than the input.
-                        This option cannot be used with plugins or `--import`.
-                        It is enabled by default, You can pass `--cache=false`
-                        to disable it.
+                        It is disabled by default.
 
   --watch               Enable watch mode. This is built on top of the
   alias: -w             `context.watch()` function of esbuild.
@@ -36,7 +37,7 @@ Options:
 
   --include:name        Force include a package in the bundle.
 
-  --node:node-options   Append node options to the command line. For example,
+  --node:options        Append node options to the command line. For example,
                         `--node:--env-file=.env` will result in the final
                         command be `node --env-file=.env outfile.js`.
 
@@ -53,3 +54,6 @@ Sub Commands:
     alias: -b
 
   temp                  Show the temp directory of the current project.
+  alias: tmp
+
+    --cwd=...           Set the current working directory.

test/cache.dep.ts

@@ -0,0 +1 @@
+export const dep = 1;

test/cache.ts

@@ -0,0 +1,3 @@
+// node dist/bin.js --cache test/cache.ts
+import * as dep from "./cache.dep";
+console.log(structuredClone(dep));

tsconfig.json

@@ -15,9 +15,9 @@
     "esModuleInterop": true,
     "resolveJsonModule": true,
     "lib": ["ESNext"],
-    "module": "ESNext",
+    "module": "Preserve",
     "target": "ESNext",
-    "moduleResolution": "Node",
+    "moduleDetection": "force",
     "types": ["node"]
   }
 }