From a09b34885f28aa1b95801a5c7395813da08a929d Mon Sep 17 00:00:00 2001 From: "shunquan.wang" Date: Tue, 24 Jun 2025 16:41:13 +0800 Subject: [PATCH 1/2] refactor: remove unmount logic from Overlay and InspectContextPanel components to streamline removal process --- packages/inspector-component/src/overlay/Overlay.tsx | 3 --- packages/inspector-component/src/panel/InspectContextPanel.tsx | 3 --- 2 files changed, 6 deletions(-) diff --git a/packages/inspector-component/src/overlay/Overlay.tsx b/packages/inspector-component/src/overlay/Overlay.tsx index 1652d50..82c22a3 100644 --- a/packages/inspector-component/src/overlay/Overlay.tsx +++ b/packages/inspector-component/src/overlay/Overlay.tsx @@ -68,9 +68,6 @@ export class Overlay { } public remove() { - if (this.root) { - this.root.unmount(); - } this.overlay.remove(); } } diff --git a/packages/inspector-component/src/panel/InspectContextPanel.tsx b/packages/inspector-component/src/panel/InspectContextPanel.tsx index fac083e..da517d7 100644 --- a/packages/inspector-component/src/panel/InspectContextPanel.tsx +++ b/packages/inspector-component/src/panel/InspectContextPanel.tsx @@ -60,9 +60,6 @@ export class InspectContextPanel { public remove() { this.hide(); - if (this.root) { - this.root.unmount(); - } this.panel.remove(); this.removeClickOutsideListener(); } From 28788a3403355e7d726e4aa451cf40c0c11c97ff Mon Sep 17 00:00:00 2001 From: "shunquan.wang" Date: Tue, 24 Jun 2025 17:25:39 +0800 Subject: [PATCH 2/2] chore: add changeset for patch updates to inspector-component --- .changeset/chatty-apples-taste.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chatty-apples-taste.md diff --git a/.changeset/chatty-apples-taste.md b/.changeset/chatty-apples-taste.md new file mode 100644 index 0000000..92eba52 --- /dev/null +++ b/.changeset/chatty-apples-taste.md @@ -0,0 +1,5 @@ +--- +"@hyperse/inspector-component": patch +--- + +refactor: remove unmount logic from Overlay and InspectContextPanel components to streamline removal process