Unignore floating point tests

Signed-off-by: Ludvig Liljenberg <[email protected]>

Author: ludfjig

Justfile

@@ -314,7 +314,7 @@ tar-headers: (build-rust-capi) # build-rust-capi is a dependency because we need
     tar -zcvf include.tar.gz -C {{root}}/src/hyperlight_guest_bin/third_party/ musl/include musl/arch/x86_64 printf/printf.h -C {{root}}/src/hyperlight_guest_capi include
 
 tar-static-lib: (build-rust-capi "release") (build-rust-capi "debug")
-    tar -zcvf hyperlight-guest-c-api-linux.tar.gz -C {{root}}/target/x86_64-unknown-none/ release/libhyperlight_guest_capi.a -C {{root}}/target/x86_64-unknown-none/ debug/libhyperlight_guest_capi.a
+    tar -zcvf hyperlight-guest-c-api-linux.tar.gz -C {{root}}/target/x86_64-hyperlight-none/ release/libhyperlight_guest_capi.a -C {{root}}/target/x86_64-hyperlight-none/ debug/libhyperlight_guest_capi.a
 
 # Create release notes for the given tag. The expected format is a v-prefixed version number, e.g. v0.2.0
 # For prereleases, the version should be "dev-latest"

c.just

@@ -11,15 +11,15 @@ c-flags-release-elf := '-O3'
 build-c-guests target=default-target: (build-rust-capi target) (compile-c-guest target) (link-c-guest target)
 
 build-rust-capi target=default-target:
-    cd src/hyperlight_guest_capi && cargo build --profile {{ if target == "debug" { "dev" } else { target } }}
+    cd src/hyperlight_guest_capi && cargo hyperlight build --profile {{ if target == "debug" { "dev" } else { target } }}
 
 compile-c-guest target=default-target:
     # elf
     cd src/tests/c_guests/c_simpleguest && {{ mkdir }} "./out/{{target}}" && clang -c {{ c-compile-options-elf }} {{ if target == "debug" { c-flags-debug-elf } else { c-flags-release-elf } }} main.c {{c-include-flags-elf}} -o "out/{{ target }}/main.o"
 
 link-c-guest target=default-target:
     # elf
-    cd src/tests/c_guests/c_simpleguest && ld.lld -o out/{{target}}/simpleguest {{c-linker-options-elf}} out/{{target}}/main.o -l hyperlight_guest_capi -L "{{justfile_directory()}}/target/x86_64-unknown-none/{{target}}"
+    cd src/tests/c_guests/c_simpleguest && ld.lld -o out/{{target}}/simpleguest {{c-linker-options-elf}} out/{{target}}/main.o -l hyperlight_guest_capi -L "{{justfile_directory()}}/target/x86_64-hyperlight-none/{{target}}"
 
 move-c-guests target=default-target:
     # elf

src/hyperlight_guest_capi/.cargo/config.toml

@@ -45,7 +45,6 @@ fn pass_byte_array() {
 }
 
 #[test]
-#[ignore = "Fails with mismatched float only when c .exe guest?!"]
 fn float_roundtrip() {
     let doubles = [
         0.0,
@@ -83,8 +82,11 @@ fn float_roundtrip() {
     for f in doubles.iter() {
         let res: f64 = sandbox.call("EchoDouble", *f).unwrap();
 
+        // Use == for comparison (handles -0.0 == 0.0) with special case for NaN.
+        // Note: FlatBuffers doesn't preserve -0.0 (-0.0 round-trips to 0.0) because FlatBuffers skips
+        // storing values equal to the default (as an optimization), and -0.0 == 0.0 in IEEE 754.
         assert!(
-            res.total_cmp(f).is_eq(),
+            (res.is_nan() && f.is_nan()) || res == *f,
             "Expected {:?} but got {:?}",
             f,
             res
@@ -93,8 +95,11 @@ fn float_roundtrip() {
     for f in floats.iter() {
         let res: f32 = sandbox.call("EchoFloat", *f).unwrap();
 
+        // Use == for comparison (handles -0.0 == 0.0) with special case for NaN.
+        // Note: FlatBuffers doesn't preserve -0.0 (it returns 0.0) because it skips
+        // storing values equal to the default, and -0.0 == 0.0 in IEEE 754.
         assert!(
-            res.total_cmp(f).is_eq(),
+            (res.is_nan() && f.is_nan()) || res == *f,
             "Expected {:?} but got {:?}",
             f,
             res