Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot: If all messages are nonpayble the dispatcher can do a single value transfer check #1463

Open
xermicus opened this issue Jul 26, 2023 · 0 comments
Open

Polkadot: If all messages are nonpayble the dispatcher can do a single value transfer check #1463

xermicus opened this issue Jul 26, 2023 · 0 comments
Labels
enhancement New feature or request polkadot Concerns the Polkadot target

Comments

@xermicus
Copy link
Contributor

xermicus commented Jul 26, 2023 •
edited
Loading 

   I noticed that the dispatch code no longer has a special case where if all functions are non-payable, then there is a single value transfer check which is both less code and less gas used in the error case. This could be utilized in the constructor case too.

Originally posted by @seanyoung in #1460 (review)

As pointed out. The emit version worked like that. It would spare contract code.
@xermicus xermicus added enhancement New feature or request polkadot Concerns the Polkadot target labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request polkadot Concerns the Polkadot target
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xermicus and others