Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement codegen expression Expression::StringLiteral #1453

Open
xermicus opened this issue Jul 21, 2023 · 0 comments
Open

Implement codegen expression Expression::StringLiteral #1453

xermicus opened this issue Jul 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@xermicus
Copy link
Contributor 

          As we don't use `AllocDynamicBytes`, we could just have an `Expression::StringLiteral` to cover this case.

Originally posted by @LucasSte in #1449 (comment)

This would be useful in a number of places, including the linked PR.

In emit, it should just yield a interned global string, the same as Expression::AllocDynamicBytes does if the Type is Slice
@xermicus xermicus changed the title As we don't use AllocDynamicBytes, we could just have an Expression::StringLiteral to cover this case. Implement codegen expression Expression::StringLiteral Jul 21, 2023
@xermicus xermicus added the enhancement New feature or request label Jul 21, 2023
@xermicus xermicus mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xermicus and others