Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] allow custom clients in did:web resolver, and test against https #1304

Open
gmulhearn-anonyome opened this issue Nov 20, 2024 · 0 comments

Comments

@gmulhearn-anonyome
Copy link
Contributor

https://github.com/hyperledger/aries-vcx/blob/7fc8b7908997ec9d8feadf52f052938b7755e8c8/did_core/did_methods/did_resolver_web/tests/resolution.rs#L81C10-L81C28

currently the did:web resolver constructs the hyper client for you, this makes it hard to inject custom ca certs into the client, or make custom client configurations, which makes it hard to test using the https mode - which is why we only test in http mode.

would be nice to allow clients to be injected, and switch the tests to use https. the http() mode could potentially be removed as well, since that mode doesn't abide by the did:web spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant