From e87eb37de437d61670663965f76a24050f5abb49 Mon Sep 17 00:00:00 2001
From: Patrik <patrik.stas@absa.africa>
Date: Thu, 30 Jun 2022 16:10:42 +0200
Subject: [PATCH] Add test, remove extra quotes serialized into credential
 preview attribute values (#503)

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
---
 aries_vcx/src/handlers/issuance/issuer.rs | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/aries_vcx/src/handlers/issuance/issuer.rs b/aries_vcx/src/handlers/issuance/issuer.rs
index a47d2d6ae0..6ee3b97000 100644
--- a/aries_vcx/src/handlers/issuance/issuer.rs
+++ b/aries_vcx/src/handlers/issuance/issuer.rs
@@ -25,8 +25,7 @@ pub struct IssuerConfig {
 }
 
 fn _build_credential_preview(credential_json: &str) -> VcxResult<CredentialPreviewData> {
-    trace!("Issuer::_build_credential_preview >>> credential_json: {:?}", credential_json);
-
+    trace!("Issuer::_build_credential_preview >>> credential_json: {:?}", secret!(credential_json));
     let cred_values: serde_json::Value = serde_json::from_str(credential_json)
         .map_err(|err| VcxError::from_msg(VcxErrorKind::InvalidJson, format!("Can't deserialize credential preview json. credential_json: {}, error: {:?}", credential_json, err)))?;
 
@@ -48,7 +47,7 @@ fn _build_credential_preview(credential_json: &str) -> VcxResult<CredentialPrevi
                 let (key, value) = item;
                 credential_preview = credential_preview.add_value(
                     key,
-                    &value.to_string(),
+                    value.as_str().ok_or_else(|| VcxError::from_msg(VcxErrorKind::InvalidOption, "Credential values are currently only allowed to be strings"))?,
                     MimeType::Plain,
                 );
             }
@@ -242,6 +241,20 @@ pub mod test {
         }
     }
 
+    #[tokio::test]
+    #[cfg(feature = "general_test")]
+    async fn test_build_credential_preview() {
+        let _setup = SetupMocks::init();
+        let input = json!({"name":"Alice","age":"123"}).to_string();
+        let preview = _build_credential_preview(&input).unwrap();
+        let value_name = preview.attributes.clone().into_iter().find(|x| x.name == "name").unwrap();
+        let value_age = preview.attributes.clone().into_iter().find(|x| x.name == "age").unwrap();
+        assert_eq!(value_name.name, "name");
+        assert_eq!(value_name.value, "Alice");
+        assert_eq!(value_age.name, "age");
+        assert_eq!(value_age.value, "123");
+    }
+
     #[tokio::test]
     #[cfg(feature = "general_test")]
     async fn test_cant_revoke_without_revocation_details() {