Skip to content
This repository was archived by the owner on Jan 22, 2020. It is now read-only.

Remove any remaining tested elements from beforeEach hook #125

Open
delventhalz opened this issue Sep 13, 2018 · 1 comment
Open

Remove any remaining tested elements from beforeEach hook #125

delventhalz opened this issue Sep 13, 2018 · 1 comment
Assignees
Labels
bug Something isn't working in progress

Comments

@delventhalz
Copy link
Contributor

Failures in a beforeEach hook do not report back their error messages. No test should run a the function being tested in beforeEach.

@delventhalz delventhalz added the bug Something isn't working label Sep 13, 2018
@delventhalz delventhalz changed the title Remove any tested elements from beforeEach hook Remove any remaining tested elements from beforeEach hook Sep 13, 2018
@delventhalz delventhalz self-assigned this Sep 14, 2018
@delventhalz
Copy link
Contributor Author

delventhalz added a commit to delventhalz/education-cryptomoji that referenced this issue Sep 14, 2018
Fixes hyperledger-archives#125

Running the function being tested within a before each hook is bad practice
because any error messages will be swallowed. They should be run within the
test itself.

Signed-off-by: Zac Delventhal <[email protected]>
delventhalz added a commit to delventhalz/education-cryptomoji that referenced this issue Sep 14, 2018
Fixes hyperledger-archives#125

Running the function being tested within a before each hook is bad practice
because any error messages will be swallowed. They should be run within the
test itself.

Signed-off-by: Zac Delventhal <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working in progress
Development

No branches or pull requests

1 participant