Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db connection pooling dev #5662

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Db connection pooling dev #5662

wants to merge 6 commits into from

Conversation

MSDrao
Copy link
Contributor

@MSDrao MSDrao commented Dec 2, 2024

Pull Request Checklist:

  • Positive Test Case Written by Dev
  • Automated Testing
  • Sufficient User and Developer Documentation
  • Passing Jenkins Build
  • Peer Code review and approval

Positive Test Case

  1. [Enter positive test case here]

@MSDrao MSDrao linked an issue Dec 2, 2024 that may be closed by this pull request
@martinseul martinseul requested a review from devincowan December 2, 2024 16:24
Copy link

github-actions bot commented Dec 2, 2024

Test Results

1 files   -     1  1 suites   - 1   5s ⏱️ - 1h 32m 31s
1 tests  - 1 414  0 ✅  - 1 399  0 💤  - 16  0 ❌ ±0  1 🔥 +1 
1 runs   - 1 526  0 ✅  - 1 509  0 💤  - 18  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit b6adf44. ± Comparison against base commit e31adf1.

This pull request removes 1414 tests.
hs_access_control.tests.test_basic_function.BasicFunction ‑ test_matrix_testing
hs_access_control.tests.test_basic_function.BasicFunction ‑ test_share
hs_access_control.tests.test_basic_function.BasicFunction ‑ test_share_inactive_user
hs_access_control.tests.test_communities.TestCommunities ‑ test_explanations
hs_access_control.tests.test_communities.TestCommunities ‑ test_iteration
hs_access_control.tests.test_communities.TestCommunities ‑ test_public_resources
hs_access_control.tests.test_communities.TestCommunities ‑ test_share_community_with_group
hs_access_control.tests.test_communities.TestCommunities ‑ test_share_community_with_user
hs_access_control.tests.test_communities.TestCommunities ‑ test_share_resource_with_community
hs_access_control.tests.test_communities.TestCommunities ‑ test_undo_share_community_with_group
…

♻️ This comment has been updated with latest results.

@devincowan
Copy link
Contributor

@MSDrao looks like you have some broken tests. I will review once those are resolved.

@devincowan
Copy link
Contributor

Also noting that this work will take some tooling to get pgbouncer running in k8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider connection pooling for better db performance
2 participants