Fix #239 (Google Drive crash on sync) #240
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occurs when the remote timestamp in the DB is more recent than the next (i.e. time has gone backwards). It's not possible to know which is "really" more recent here, so the safest thing to do is to report an error and skip that file.
|
Screenshot with the fix running. |
|
Extra info: The directory issue seems odd (this is a file, not a directory). I wonder if that double |
|
Note: the issue still comes up if I rerun; every time I launch the app. But this is definitely better than crashing at least. |
|
Looking at my Google drive in the Web UI, it has the same file listed twice, with different contents. Madness. Removing one of the duplicates seems to also fix the problem more permanently (with or without this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurs when the remote timestamp in the DB is more recent than the next (i.e. time has gone backwards).
It's not possible to know which is "really" more recent here, so the safest thing to do is to report an error and skip that file.
I am guessing that Google changed how timestamps worked in the 11th November update 🤷♀️